-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
watch.vue,watches.vueをVueMounterに対応させた #5503
Conversation
637fe44
to
adf1a8f
Compare
@choco0809 |
@keiz1213 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keiz1213
遅くなってしまい申し訳ございません🙇♂️
コード、動作ともに問題はなかったのですがconflictが発生しているように思えますので、
そちらだけ解消していただければと思います🙇♂️🙇♂️🙇♂️
adf1a8f
to
34941cf
Compare
@choco0809 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keiz1213
コード、動作ともに問題ないことを確認しましたので、Approveさせていただきます!!
@choco0809 @komagata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
確認させて頂きました。OKです〜🙆♂️
issue
概要
watch.vue,watches.vueのマウント方法を従来の方法からVueMounterで一元的にマウント管理する方法に変更しました。
見た目上の変更はありません。
変更確認方法
chore/watches-for-vue_mounter
をローカルに取り込むrails s
で立ち上げる