ブログのpublished_at=nilかつwip=falseでもindexとshowが表示されるようにする #4200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaisumi
changed the title
|
以下の問題によりテストを通過できません： |
kaisumi
commented
Feb 10, 2022
lib/tasks/bootcamp.rake
Outdated
Comment on lines
43
to
49
| Article.where(wip: false).where(published_at: nil).find_each do |article| | ||
| article.published_at = article.created_at | ||
| article.save!(validate: false) | ||
| end | ||
|
|
There was a problem hiding this comment.
この部分はCloud Buildでの動作確認ができなかったため、確認をお願いいたします。
|
@komagata お手数をおかけし申し訳ございません。こちらレビューをよろしくお願いいたします 🙇 |
|
@kaisumi mainブランチや他のブランチはテスト通っているようなのでそちらとの差分を含めてテストが通るように調査してみてください〜 |
kaisumi
force-pushed
the
bug/articles_index_error_500_with_published_at_nil_fix
branch
from
fcbe090
to
872b0df
Compare
|
@komagata mainを取り込んでテストが通るようにしました。ご確認をお願いいたします 🙏 |
komagata
deleted the
bug/articles_index_error_500_with_published_at_nil_fix
branch
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
該当のPR
経緯
ブログにWIP機能をつけた際、published_atカラムを追加し、一覧画面に表示されるのがpublished_atになりました。
考えられる原因
ステージング環境ではデータマイグレーションが行われないとのことで、wip=false&&published_at=nilとなり、エラーが発生していると考えられます。
対策内容
https://github.com/fjordllc/bootcamp/blob/main/lib/tasks/bootcamp.rake#L39
対策結果
FJORD.BOOT.CAMP.-.Google.Chrome.2022-02-16.12-53-50.mp4
_.FJORD.BOOT.CAMP.-.Google.Chrome.2022-02-16.12-57-05.mp4