-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ユーザーの検索結果に、管理者でログインしたときだけそのユーザーの相談部屋へのリンクを表示 #4147
Merged
komagata
merged 28 commits into
main
from
display-link-to-consultation-room-in-users-search-results
Mar 10, 2022
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
8790657
first commit
ot0m1 f859a3f
相談部屋へのリンクを表示
ot0m1 5b38b4a
冗長な条件分岐をリファクタリング
ot0m1 b0f7b84
さらにリファクタリング
ot0m1 1142061
rubocop通した
ot0m1 4059f8d
さらにリファクタリング
ot0m1 4c85f20
クリップボードのテストを通るように修正
ot0m1 1bea353
talk?メソッドの返り値をbooleanのみに
ot0m1 8e9eea5
メソッド名を具体的に
ot0m1 11ea071
管理者だけにリンクが表示されるように変更
ot0m1 9cdc350
不要な条件分岐を削除
ot0m1 f9d98ee
管理者かを判断するロジックをVue側に持たせた
ot0m1 65cfe98
テストを追加
ot0m1 cc300ee
最新の origin/mian を取り込み
ot0m1 fe5ba3d
テストの条件を変更
ot0m1 33b922b
ヘルパーのテストを追加
ot0m1 fba40bd
テスト名を修正
ot0m1 6522a73
不要なヘルパーメソッドを削除
ot0m1 0072d92
不要なヘルパーテストを削除
ot0m1 634086f
テストのパターンを追加
ot0m1 8a7fa44
不要なスペースを削除
ot0m1 f6fc8a7
テストが通るように最新の origin/main を取り込み
ot0m1 7f133ba
テスト名を変更
ot0m1 028fd7e
テストが通るように最新の origin/main を取り込み
ot0m1 57c1b36
適切なアサーションに修正
ot0m1 e2093ac
間違った assert の引数を修正
ot0m1 ad279f9
冗長な変数宣言を削除
ot0m1 4b9677e
テストを分割
ot0m1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
# frozen_string_literal: true | ||
|
||
require 'test_helper' | ||
|
||
class SearchHelperTest < ActionView::TestCase | ||
test 'return whether talk' do | ||
assert talk?(users(:kimura)) | ||
assert_not talk?(users(:taikai3)) | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
対応するhelperのテストがあるといいかもです〜
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ヘルパーテストを追加するみたいな考えが全くありませんでした🙏
追加しました。