日報のテキストエリアの高さが自動で大きくなることを確認するテストを追加 #4143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eatplaynap |
eatplaynap
requested changes
Feb 7, 2022
There was a problem hiding this comment.
@R-Tsukada
実装お疲れさまです〜！テストコードをちゃんと読んだことがなかったのでとても勉強になりました！
テストの内容は問題なさそうですが、テスト名はハイフン無しに変更した方が統一感があってよさそうだと思いました😄
コメントに自分だったらこういうテスト名にするかな…と考えてみましたが、ご参考にされるかはおまかせします！！
|
@eatplaynap |
|
@R-Tsukada |
|
@eatplaynap |
|
@komagata |
komagata
approved these changes
Feb 9, 2022
komagata
deleted the
feature/textarea-of-report-automatically-resize-test
branch
54 tasks
eatplaynap
requested review from
eatplaynap
and removed request for
eatplaynap
|
@R-Tsukada |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#issue4057
概要
日報のテキストエリアの高さが、文字数に応じて自動で大きくなることを確認するテストを追加しました。
以前に日報がnew以外のときにmarkdownが効かなくなったことがあるようなので（こちらのPR)、新規作成時と編集時のテストを追加しています。