Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

未アサインの提出物のページングを削除 #3441

Merged
merged 3 commits into from
Oct 26, 2021

Conversation

Ichiyo14
Copy link
Contributor

@Ichiyo14 Ichiyo14 commented Oct 24, 2021

issue: #3174

未アサインの提出物ページ(/products/unassigned)は件数が51件以上の場合ページングされていたが、一度に全件を俯瞰できるようにページングを削除した。

参考PR:#3075

編集前

スクリーンショット 2021-10-25 13 13 45

編集後

スクリーンショット 2021-10-25 13 13 55

@Ichiyo14 Ichiyo14 self-assigned this Oct 25, 2021
@Ichiyo14
Copy link
Contributor Author

@mami-inuzuka
お時間ある時にこちらのレビューをお願いします🙏

@Ichiyo14 Ichiyo14 requested a review from mami-inuzuka October 25, 2021 04:57
@mami-inuzuka
Copy link
Contributor

@Ichiyo14 確認しました!良いと思います〜!😊👌

@Ichiyo14 Ichiyo14 marked this pull request as ready for review October 25, 2021 09:04
@Ichiyo14
Copy link
Contributor Author

@mami-inuzuka
ご確認ありがとうございます!

@komagata
こちらのレビューをお願いします🙏

@Ichiyo14 Ichiyo14 requested a review from komagata October 25, 2021 10:02
Copy link
Member

@komagata komagata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認しました、OKですー🙆‍♂️

@komagata komagata merged commit 6a884a6 into main Oct 26, 2021
@komagata komagata deleted the feature/remove-paging-for-unassigned-submissions branch October 26, 2021 08:04
@github-actions github-actions bot mentioned this pull request Oct 26, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants