プラクティス個別ページのDocsのタブにDocの数を表示 #3406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@konaga-k |
konaga-k
approved these changes
Oct 17, 2021
db/fixtures/pages.yml
Outdated
Comment on lines
46
to
52
|
|
||
| page7: | ||
| title: プラクティスに紐付いたDocs | ||
| body: プラクティスに紐付いている | ||
| user: komagata | ||
| practice: practice1 | ||
| published_at: "2021-10-01 00:00:00" |
There was a problem hiding this comment.
基本的に db/fixtures と test/fixtures の同名ファイルの中身は一致させている気がします
なので test/fixtures/pages.yml にも page7 を追加して欲しいと思ったんですが、 pages.yml の場合は page6 の内容が違っちゃってますね…
https://github.com/fjordllc/bootcamp/blob/feature/show-the-number-of-docs-in-the-docs-tab/test/fixtures/pages.yml
対応方針が分からないので駒形さんに聞いてみる
@komagata
db/fixtures と test/fixtures の同名ファイルの中身ってできるだけ一致させたほうがいいんでしょうか？
元から中身が一致しているものもあれば今回の pages.yml の page6 のように不一致なものもあります
page6 のような既存のデータを今から一致させる必要まではないと思うんですが、これから追加するデータについては db/fixtures と test/fixtures の両方に追加したほうがいいんでしょうか？
|
@komagata |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #3392
プラクティス個別ページのDocsのタブにDocの数を表示した。
変更前イメージ
変更後イメージ