Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2021-10-01 14:11:20 #3313

Merged
merged 103 commits into from
Oct 4, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
103 commits
Select commit Hold shift + click to select a range
63cf311
提出物に最終コメント日時を追加
gentamura Sep 12, 2021
2401010
Merge branch 'bug/fix-delete-error-with-comments-in-products' into fe…
gentamura Sep 12, 2021
3593202
既存の提出物にcommented_atを追加するrakefileを追加
gentamura Sep 12, 2021
6f7d217
分報URLとしてDiscordのチャンネルURLを登録できるようにする
rikuba Aug 16, 2021
331c819
登録情報変更ページの分報チャンネルのプレースホルダをチャンネルURLに変更
rikuba Aug 16, 2021
92e9cb7
登録情報変更ページに分報URLの調べ方のヘルプを追加
rikuba Aug 16, 2021
ea5b9b8
管理者としてユーザー情報の分報URLを変更できるようにする
rikuba Sep 5, 2021
9eeb97e
分報URLについてのテストの名前を意図が分かりやすくなるように修正
rikuba Sep 8, 2021
c0be67a
DiscordのチャンネルURLを取得する正規表現を修正
rikuba Sep 8, 2021
12bb034
分報URLの招待URLをチャンネルURLに変換するデータマイグレーションを追加
rikuba Sep 15, 2021
47e0c70
分報URLをメッセージURLからチャンネルURLに変換する処理をユーザーモデルで行う
rikuba Sep 17, 2021
3d1d9e6
分報URLのvalidationでチャンネルURLのみ受け入れるようにする
rikuba Sep 17, 2021
82badd6
分報URLのデータマイグレーション時、無効な招待URLの場合は分報URLを消去する
rikuba Sep 17, 2021
f850084
分報URLのデータマイグレーションのテストを追加
rikuba Sep 19, 2021
e6a80d1
コンフリクトの解消
udaikue Aug 21, 2021
e6eb2f6
コース一覧に表示・非表示を表示させる
udaikue Aug 5, 2021
08b4440
コース編集画面に表示・非表示のチェックボックスを作成
udaikue Aug 13, 2021
f6b5779
{}内をスペースを追加
udaikue Aug 13, 2021
c14da21
追加したカラムをparamsに追加して編集できるようにした
udaikue Aug 13, 2021
bc1d757
チェックボックスのオプション・クラス名を修正
udaikue Aug 13, 2021
df59025
システムテストを追記
udaikue Aug 13, 2021
33e8b84
管理者以外の人は非表示になっているコースは見れないようにした
udaikue Aug 21, 2021
d2d65ab
コース選択のclosedのデザイン、コース編集のopen close の選択のデザイン
machida Aug 18, 2021
d1f16de
コース編集画面の横幅に制限を付けた
machida Aug 25, 2021
a1912a8
コース名が表示されないバグを修正
machida Sep 8, 2021
202e5ab
文字色変更
machida Sep 8, 2021
17383fa
コンフリクトの解消
udaikue Aug 21, 2021
13e6633
コース選択のclosedのデザイン、コース編集のopen close の選択のデザイン
machida Aug 18, 2021
10064d6
テストを修正
udaikue Sep 11, 2021
cc01d2a
リファクタリング
udaikue Sep 11, 2021
561932f
コンフリクトを解消
udaikue Sep 16, 2021
4443151
日報個別ページにユーザー名を表示
kaiyu-tech Sep 23, 2021
9969c71
ダッシュボードのタブ名を自分のWatch中からWatch中に変更
haruguchi-yuma Sep 23, 2021
0ab7297
カラム名を修正
udaikue Sep 23, 2021
809a315
watches/index.html.slimの自分のWatch中をWatch中に変更した
haruguchi-yuma Sep 23, 2021
06d968a
テストの自分のWatch中をWatch中に変更
haruguchi-yuma Sep 24, 2021
daef73a
プラクティスに質問がない場合に泣き顔を表示するようにした
Sep 24, 2021
b61fada
footerのメニューにTwitterの#fjordbootcampへのリンクを追加
kaiyu-tech Sep 24, 2021
29fdb50
Merge pull request #3093 from fjordllc/feature/users-can-select-a-course
komagata Sep 25, 2021
6f5dc6f
Merge pull request #3304 from fjordllc/feature/user_name_daily_report…
komagata Sep 25, 2021
3b9f296
Merge pull request #3305 from fjordllc/feature/change_dashbord_tabnam…
komagata Sep 25, 2021
d446558
分報URLをメッセージURLからチャンネルURLに変換する処理を削除
rikuba Sep 26, 2021
1d2fca6
分報URLのヘルプをブラウザから調べる方法の説明に変更
rikuba Sep 26, 2021
9495fc2
提出物の並び順を変更
konaga-k Sep 5, 2021
353cce3
Product.listからorderを分離、長すぎるメソッドチェインを改行
konaga-k Sep 5, 2021
bbc34dc
自分の担当の提出物の並び順を作成日か提出日かで間違えたときに、テストが失敗するように修正
konaga-k Sep 5, 2021
768cb96
テストの期待結果の説明を修正
konaga-k Sep 5, 2021
bbb6f11
提出物の並び順のテストを追加
konaga-k Sep 5, 2021
6e79535
product.rbのスコープでorderとwhereを分離、reorderは不要のためorderに変更
konaga-k Sep 5, 2021
9e1760b
Rubocop修正
konaga-k Sep 5, 2021
b6004e4
テスト名の重複解消
konaga-k Sep 5, 2021
d85a50f
typo修正
konaga-k Sep 5, 2021
3a675e9
failureになるテストを修正
konaga-k Sep 5, 2021
5c23522
右サイドメニューの日報一覧で生じるN+1を解消
konaga-k Sep 16, 2021
9cd2dfd
定数のスコープを狭めるため宣言をTestクラスの中に移動
konaga-k Sep 16, 2021
e9f9309
Followingテーブルにwatchを追加
yana-gi Sep 5, 2021
4b348e8
watch=falseの場合、自動的にWatchしないようにした
yana-gi Sep 5, 2021
24867f0
Following.watchを切り替えられるようにした
yana-gi Sep 5, 2021
50a49ed
ビュー側でフォローできるようにした
yana-gi Sep 7, 2021
74ce810
コメントなしボタンを追加
yana-gi Sep 7, 2021
2eceba3
フォローしないボタンを追加
yana-gi Sep 7, 2021
767538a
usersにクエリパラメータにwatchを追加
yana-gi Sep 13, 2021
d23dae6
文言・デザイン仮追加
yana-gi Sep 13, 2021
665f94e
フォローボタンの表示を変更
yana-gi Sep 14, 2021
ef101c8
usersの「フォロー中」の階層を1段階あげた
yana-gi Sep 14, 2021
7fb7975
フォローボタンのデザイン、タブ周りの色調整
machida Sep 17, 2021
df2fb34
モデルテスト追加
yana-gi Sep 19, 2021
455966a
システムテスト追加
yana-gi Sep 19, 2021
15f0768
テストデータ追加
yana-gi Sep 19, 2021
3b2d9a7
エラー発生時の文言を修正
yana-gi Sep 21, 2021
9cc96eb
lint修正
yana-gi Sep 21, 2021
bb32343
User#followにキーワード引数を設定した
yana-gi Sep 22, 2021
3f3f97f
User#change_watching の更新処理を update! から update に変更
yana-gi Sep 22, 2021
774512e
User#following_list の処理変更
yana-gi Sep 22, 2021
329e103
User#auto_watching? の名前を watching? に変更
yana-gi Sep 22, 2021
fa8a40a
boolean属性の指定に?を付与
yana-gi Sep 22, 2021
4546e9e
不要なファイルを削除
yana-gi Sep 22, 2021
ca9b433
User#follow の処理を変更
yana-gi Sep 22, 2021
c18e8c2
フォローの説明が消えてしまっていたのを修正、通知のデザインファイルを消してしまっていたのを戻した
machida Sep 27, 2021
0ae2a80
フィヨルドブートキャンプへようこその幅を調整
machida Sep 27, 2021
02b3e01
インデント修正
machida Sep 27, 2021
41b12f1
Merge pull request #3317 from fjordllc/welcome-message-width
machida Sep 27, 2021
3feae3f
Bump nokogiri from 1.12.3 to 1.12.5
dependabot[bot] Sep 27, 2021
2f65ecc
comment更新のmethodを変更
gentamura Sep 28, 2021
fa40ccf
taskをdata_migrateに移管
gentamura Sep 28, 2021
985a923
カナの入力でヴが使えない問題を修正
komagata Sep 28, 2021
4407a30
Merge branch 'main' into feature/add-commented-at-in-products
gentamura Sep 28, 2021
d51e3a4
Merge pull request #3322 from fjordllc/bug/katakana-validation
komagata Sep 28, 2021
995a47a
「フォロー中」のタブのアクティブ状態を修正
yana-gi Sep 28, 2021
07e70e8
Merge pull request #3320 from fjordllc/dependabot/bundler/nokogiri-1.…
komagata Sep 28, 2021
9f93461
Merge pull request #3228 from fjordllc/feature/reorder-products
komagata Sep 28, 2021
4904f16
Merge pull request #3307 from fjordllc/feature/change-appearance-of-p…
komagata Sep 28, 2021
34c85e5
Merge pull request #3309 from fjordllc/feature/add_twitter_link_in_fo…
komagata Sep 28, 2021
e8c275b
テストしやすいようにデータマイグレーションで行っていた処理をユーザーモデルに移動
rikuba Sep 29, 2021
db9290c
Merge pull request #3139 from fjordllc/bug/fix-times-url
komagata Sep 29, 2021
e4aaa14
Merge pull request #3227 from fjordllc/feature/enable_choose_type_of_…
machida Sep 30, 2021
6056c53
データ更新をdata migrateからcloud buildのtaskに変更
gentamura Sep 30, 2021
4359512
WatchをしたときにtoastでWatchをしたことを通知
kaiyu-tech Sep 30, 2021
4aa3084
ブックマークが無いときの表示を変更
Ichiyo14 Sep 30, 2021
356054b
インデントの変更によるネスト関係の修正
Ichiyo14 Oct 1, 2021
84a4914
Merge pull request #3264 from fjordllc/feature/add-commented-at-in-pr…
komagata Oct 1, 2021
8b5c9a2
Merge pull request #3334 from fjordllc/feature/inform_watching_by_toast
komagata Oct 1, 2021
c3678be
Merge pull request #3335 from fjordllc/feature/display-when-there-are…
komagata Oct 1, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -241,10 +241,10 @@ GEM
net-http-persistent (3.1.0)
connection_pool (~> 2.2)
nio4r (2.5.8)
nokogiri (1.12.3)
nokogiri (1.12.5)
mini_portile2 (~> 2.6.1)
racc (~> 1.4)
nokogiri (1.12.3-x86_64-darwin)
nokogiri (1.12.5-x86_64-darwin)
racc (~> 1.4)
oauth (0.5.5)
oauth2 (1.4.4)
Expand Down
Binary file added app/assets/images/help/discord-channel-url.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 10 additions & 0 deletions app/assets/stylesheets/atoms/_a-dropdown.sass
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
.a-dropdown
overflow: hidden
background-color: $base
border: solid 1px $border-shade
box-shadow: rgba(black, .2) 0 0 .375rem
border-radius: .25rem

.a-dropdown__item
&:not(:last-child)
border-bottom: solid 1px $border
2 changes: 2 additions & 0 deletions app/assets/stylesheets/blocks/card/_card-main-actions.sass
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
&.is-end
margin-left: auto
flex-basis: 2.5rem
+media-breakpoint-down(sm)
margin-bottom: 0

.card-main-actions__delete
+hover-link-reversal
Expand Down
27 changes: 25 additions & 2 deletions app/assets/stylesheets/blocks/course/_courses.sass
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,33 @@
.courses-item__title
+text-block(1.125rem 1.4)

.courses-item__title-icon
+text-block(.6875rem, inline-flex $semi-muted-text nowrap 400)
+padding(horizontal, .5rem)
height: 1.125rem
margin-right: .5rem
border-radius: .75rem
align-items: center
justify-content: center
+media-breakpoint-up(md)
+position(relative, top -.125rem)
+media-breakpoint-down(sm)
+position(relative, top -.1875rem)
&.is-closed
background-color: #e9ebef

.courses-item__title-link
display: block
+block-link

.courses-item__title-label
color: $main-text
+hover-link
transition: all .2s ease-out
.is-closed &
color: $muted-text
.is-closed .courses-item__title-link:hover &,
.courses-item__title-link:hover &
text-decoration: underline
color: $main-text

.courses-item__description
padding: .5rem 1.25rem 1.25rem
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
.header-notification-icon
+text-block(1.25rem 1, center)
+media-breakpoint-down(sm)
+text-block(1.125rem 1)
.has-count &
color: $default-text

.header-notification-count
background-color: $badge-color
+text-block(.625rem 1, center $reversal-text flex)
align-items: center
justify-content: center
border-radius: 1rem
position: absolute
+media-breakpoint-up(md)
+size(1.25rem .875rem)
+position(right .25rem, top .25rem)
+media-breakpoint-down(sm)
+size(1.125rem .75rem)
+position(right .125rem, top .125rem)

.header-notifications-item__body
width: 100%
+media-breakpoint-up(md)
color: $default-text
+media-breakpoint-down(sm)
color: $reversal-text

.header-notifications-item__user-icon
float: left
+size(2rem)
margin-right: .5rem
margin-bottom: .25rem

.header-notifications-item__message
p
line-height: 1.45
margin-bottom: .375em
+media-breakpoint-up(md)
font-size: .8125rem
+media-breakpoint-down(sm)
font-size: .75rem

.header-notifications-item__created-at
text-align: right
display: block
+media-breakpoint-up(md)
font-size: .75rem
+media-breakpoint-down(sm)
font-size: .625rem
119 changes: 0 additions & 119 deletions app/assets/stylesheets/blocks/header/_header-drop-down.sass

This file was deleted.

4 changes: 2 additions & 2 deletions app/assets/stylesheets/blocks/header/_header-dropdown.sass
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@

.header-dropdown__inner
+media-breakpoint-up(md)
background-color: $base
+position(absolute, right 0, top 100%, 2)
background-color: $base
border: solid 1px $border-shade
width: 14rem
box-shadow: rgba(black, .2) 0 0 .375rem
Expand Down Expand Up @@ -63,7 +63,7 @@
.header-dropdown__item:not(:last-child) &
border-bottom: solid 1px $background
&:hover
background-color: $background-more-tint
background-color: $hover-background
+media-breakpoint-down(sm)
color: $reversal-text
border-bottom: solid 1px $side-border
Expand Down
2 changes: 1 addition & 1 deletion app/assets/stylesheets/blocks/page/_page-tabs.sass
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

.page-tabs__item-link
+flex-link
+text-block(.825rem 1, $default-text 600)
+text-block(.825rem 1, $semi-muted-text 600)
align-items: center
justify-content: center
height: 2.75rem
Expand Down
6 changes: 3 additions & 3 deletions app/assets/stylesheets/blocks/shared/_tab-nav.sass
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,14 @@

.tab-nav__item-link
+block-link
+text-block(.75rem 2.3, $muted-text center nowrap)
+text-block(.75rem 2.3, $semi-muted-text center nowrap)
background-color: $background-shade
border-radius: 20rem
width: 7rem
transition: all.2s ease-out
&:hover
background-color: shade($background-shade, 10%)
color: $main-text
color: $default-text
&.is-active
background-color: $accent
color: $main-text
color: $default-text
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
align-items: flex-start

.thread-list-item-title__icon
+text-block(.75rem, inline-flex $muted-text nowrap)
+text-block(.75rem, inline-flex $semi-muted-text nowrap 400)
margin-top: .25rem
+padding(horizontal, .5rem)
height: 1.125rem
Expand Down
32 changes: 32 additions & 0 deletions app/assets/stylesheets/blocks/user/_following.sass
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
.following
position: relative

.following__dropdown
+position(absolute, 2)
width: 18.75rem

.following-option
cursor: pointer
width: 100%
padding: .75rem
display: block
text-align: left
transition: all .2s ease-out
&:hover
background-color: $hover-background

.following-option__inner
position: relative
padding-left: 1.5rem
.following-option.is-active &::before
+fa(fas '\f00c')
+position(absolute, left 0, top 0)

.following-option__label
+text-block(.875rem 1.4, 600 $semi-muted-text)
.following-option.is-active &
color: $default-text

.following-option__desciption
+text-block(.75rem 1.5, $muted-text)
margin-top: .125rem
3 changes: 2 additions & 1 deletion app/assets/stylesheets/initializers/_reset.sass
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,6 @@ hr
border: none

details,
details *
details *,
summary
box-sizing: border-box
2 changes: 1 addition & 1 deletion app/assets/stylesheets/mixins/_button.sass
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
&.is-block
display: flex
width: 100%
max-width: 100%
&.is-select
+margin(horizontal, 0)
&:focus
Expand All @@ -30,7 +31,6 @@
margin-right: .35em
margin-top: .02em
font-size: 1.07em
font-weight: normal
&.is-icon
i
+text-block(1.3em 1)
Expand Down
2 changes: 2 additions & 0 deletions app/assets/stylesheets/variables/_colors.sass
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ $background: #ececec
$background-shade: #d6d6d6
$background-tint: #eceeef
$background-more-tint: #f7f7f9
$hover-background: $background-more-tint


$default-text: #403f47
$reversal-text: white
Expand Down
2 changes: 1 addition & 1 deletion app/controllers/admin/users_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def user_params
:adviser, :login_name, :name,
:name_kana, :email, :course_id,
:description, :discord_account, :github_account,
:twitter_account, :facebook_url, :blog_url,
:twitter_account, :facebook_url, :blog_url, :times_url,
:password, :password_confirmation, :job,
:organization, :os, :study_place,
:experience, :prefecture_code, :company_id,
Expand Down
13 changes: 12 additions & 1 deletion app/controllers/api/followings_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,24 @@ class API::FollowingsController < API::BaseController

def create
user = User.find(params[:id])
if current_user.follow(user)
watch = params[:watch] == 'true'
if current_user.follow(user, watch: watch)
render json: { id: user.id }
else
head :bad_request
end
end

def update
user = User.find(params[:id])
watch = params[:watch] == 'true'
if current_user.change_watching(user, watch)
head :no_content
else
head :bad_request
end
end

def destroy
user = User.find(params[:id])
if current_user.unfollow(user)
Expand Down
Loading