Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert to python3.8 #27

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix: revert to python3.8 #27

merged 1 commit into from
Aug 26, 2024

Conversation

cooper667
Copy link
Collaborator

@cooper667 cooper667 commented Aug 26, 2024

Description

Jenkins (and therefore all the AWS deploys) are running Python 3.8. This PR rolls back the dependency on Python 3.11 (which azure was using) so it can be used there.

Dependency Changes (delete if not applicable)

Python3.11 -> Python 3.8

Testing

  • I have manually ran the pipeline on Azure and Pipenv was successful (with a warning about running expecting 3.8 while running on 3.11, but that doesn't matter I dont think?). The pipeline ran successfully

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

Copy link
Member

@ChasNelson1990 ChasNelson1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do an AFRO Staging full deploy to test this once merged? Just in case we are asked to do any hot fixes for Prod this week.

@cooper667
Copy link
Collaborator Author

Can you do an AFRO Staging full deploy to test this once merged? Just in case we are asked to do any hot fixes for Prod this week.

That's what I did to test it (not all the infra, but the kubernetes part)

@cooper667 cooper667 merged commit a200840 into master Aug 26, 2024
@cooper667 cooper667 deleted the py3.8 branch August 26, 2024 10:10
Copy link

🚀 [bumpr] Bumped! New version:v1.2.0 Changes:v1.1.1...v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bump:minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants