Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

169 - ZaRR to ZaRER #33

Closed
wants to merge 2 commits into from
Closed

169 - ZaRR to ZaRER #33

wants to merge 2 commits into from

Conversation

A-Souhei
Copy link
Contributor

@A-Souhei A-Souhei commented Sep 25, 2024 •
edited
Loading

Description

Changes "ZaRR" to "ZARER" abbreviation from "Zambia Research and Evaluation Repository"

Closes fjelltopp/zarr-ckan#169

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

@A-Souhei A-Souhei self-assigned this Sep 25, 2024
@A-Souhei A-Souhei added the bug Something isn't working label Sep 25, 2024
@A-Souhei A-Souhei marked this pull request as ready for review September 25, 2024 11:27
ChasNelson1990
ChasNelson1990 requested changes Sep 25, 2024
View reviewed changes
Copy link
Member

@ChasNelson1990 ChasNelson1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's stick to ZaRR.... its the order of the full name we need change to Zambia Research and Evaluation Repository (not Zambia Evaluation and Research Repository)

@A-Souhei
Copy link
Contributor Author

@ChasNelson1990 I understand, I will close this PR then and make a small one to change the readme.md.

@A-Souhei A-Souhei closed this Sep 25, 2024
@A-Souhei A-Souhei deleted the 169-turns-out-we-have-the-name-wrong branch September 25, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChasNelson1990 ChasNelson1990 ChasNelson1990 requested changes

Assignees

@A-Souhei A-Souhei

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turns out we have the name wrong
2 participants
@A-Souhei @ChasNelson1990