Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a placeholder video to the homepage #23

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

ChasNelson1990
Copy link
Member

Description

Uses the insights block to add a video. The idea is that the client will replace this with an introduction to the repository, ideally featuring the minister or somebody high up.

closes fjelltopp/zarr-ckan#146

On laptop:
image

On phone:
image

Internationalisation and Localisation

Strings are i18n friendly but not translated. This is probably fine for this client.

Checklist

  • The GitHub ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

@ChasNelson1990 ChasNelson1990 added the enhancement New feature or request label Aug 30, 2024
@ChasNelson1990 ChasNelson1990 self-assigned this Aug 30, 2024
@ChasNelson1990 ChasNelson1990 enabled auto-merge (squash) August 30, 2024 12:50
Copy link
Contributor

@A-Souhei A-Souhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

image

@ChasNelson1990 ChasNelson1990 merged commit 1254dda into main Aug 30, 2024
2 checks passed
@ChasNelson1990 ChasNelson1990 deleted the feat-placeholder-video branch August 30, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide green section on the home page - maybe “our vision” and a link to “documentation (coming)”
2 participants