Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghc 8.4.1 #71

Merged
merged 2 commits into from
Mar 14, 2018
Merged

Ghc 8.4.1 #71

merged 2 commits into from
Mar 14, 2018

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Mar 8, 2018

No description provided.

@phadej
Copy link
Collaborator Author

phadej commented Mar 8, 2018

blocked on blaze-builder

@DanBurton
Copy link

blaze-builder-0.4.1.0 has been released, which should unblock this. A prompt release would be much appreciated, as I'd love to get this into the next Stackage nightly!

@phadej
Copy link
Collaborator Author

phadej commented Mar 14, 2018

@DanBurton thanks for pinging

@DanBurton
Copy link

DanBurton commented Mar 14, 2018

I have observed passing tests from the latest commit on this PR, like so:

stack upgrade --git --git-branch stable
git clone https://github.com/phadej/http-api-data
cd http-api-data/
git checkout 1f8ef4fb381d7bfa5ede6e6752b4bf97b1701904
edit stack-ghc-8-4.yaml # add the following yaml file
stack --stack-yaml stack-ghc-8-4.yaml test
resolver: nightly-2018-03-14

packages:
- '.'

flags:
  http-api-data:
    use-text-show: false

extra-deps:
- uri-bytestring-0.3.1.1
- blaze-builder-0.4.1.0
- quickcheck-instances-0.3.18
- uuid-1.3.13
- doctest-0.14.1
- cryptohash-md5-0.11.100.1
- cryptohash-sha1-0.11.100.1
- entropy-0.3.8
- network-info-0.2.0.9

allow-newer: true

extra-package-dbs: []

Unfortunately, allow-newer: true was necessary in order to convince the following bounds to be ignored:

WARNING: Ignoring out of range dependency (allow-newer enabled): base-4.11.0.0. cryptohash-md5 requires: >=4.5 && <4.11
WARNING: Ignoring out of range dependency (allow-newer enabled): base-4.11.0.0. cryptohash-sha1 requires: >=4.5 && <4.11
WARNING: Ignoring out of range dependency (allow-newer enabled): Cabal-2.2.0.0. entropy requires: >=1.10 && <2.2

Note, however, that these particular dependencies were only necessary for testing, and not for the package itself. I am explaining this in order to lend confidence to merging and releasing this PR, despite difficulties you may encounter while testing it (since uuid's deps remain overconstrained for ghc-8.4.1).

Also note that you could relax your constraint on doctest to < 0.16, as the same passing tests can be observed with doctest-0.15.0.

Also relax doctest
@phadej
Copy link
Collaborator Author

phadej commented Mar 14, 2018

@DanBurton thanks for mentioning doctest-0.15, I'd forgot that otherwise.

@phadej
Copy link
Collaborator Author

phadej commented Mar 14, 2018

For the record: there is install plan without cryptohash-* and entropy, they were unnecessarily pulled by uuid (we are good with uuid-types only)

@phadej phadej merged commit ffac6a5 into fizruk:master Mar 14, 2018
@phadej
Copy link
Collaborator Author

phadej commented Mar 14, 2018

released as https://hackage.haskell.org/package/http-api-data-0.3.8.1

@phadej phadej deleted the ghc-8.4.1 branch March 14, 2018 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants