-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ghc 8.4.1 #71
Ghc 8.4.1 #71
Conversation
blocked on blaze-builder |
blaze-builder-0.4.1.0 has been released, which should unblock this. A prompt release would be much appreciated, as I'd love to get this into the next Stackage nightly! |
@DanBurton thanks for pinging |
I have observed passing tests from the latest commit on this PR, like so: stack upgrade --git --git-branch stable
git clone https://github.com/phadej/http-api-data
cd http-api-data/
git checkout 1f8ef4fb381d7bfa5ede6e6752b4bf97b1701904
edit stack-ghc-8-4.yaml # add the following yaml file
stack --stack-yaml stack-ghc-8-4.yaml test resolver: nightly-2018-03-14
packages:
- '.'
flags:
http-api-data:
use-text-show: false
extra-deps:
- uri-bytestring-0.3.1.1
- blaze-builder-0.4.1.0
- quickcheck-instances-0.3.18
- uuid-1.3.13
- doctest-0.14.1
- cryptohash-md5-0.11.100.1
- cryptohash-sha1-0.11.100.1
- entropy-0.3.8
- network-info-0.2.0.9
allow-newer: true
extra-package-dbs: [] Unfortunately,
Note, however, that these particular dependencies were only necessary for testing, and not for the package itself. I am explaining this in order to lend confidence to merging and releasing this PR, despite difficulties you may encounter while testing it (since Also note that you could relax your constraint on |
Also relax doctest
@DanBurton thanks for mentioning doctest-0.15, I'd forgot that otherwise. |
For the record: there is install plan without cryptohash-* and entropy, they were unnecessarily pulled by |
No description provided.