Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghc 8.2 #44

Merged
merged 12 commits into from
Jan 17, 2017
Merged

Ghc 8.2 #44

merged 12 commits into from
Jan 17, 2017

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Jan 12, 2017

(will) resolve #43 (and #42).

@phadej
Copy link
Collaborator Author

phadej commented Jan 12, 2017

This is directly based on ekmett/bytes#32 with small additions.

I can revert .travis.yml to the HEAD state (and use stack). But I like this setup.

Also for the record: 0.3 version uses closed type families, so GHC >= 7.8 is hard requirement.

@fizruk
Copy link
Owner

fizruk commented Jan 13, 2017

@phadej you now have write access to this repository.

@phadej
Copy link
Collaborator Author

phadej commented Jan 13, 2017

I'm still experimenting with making setup.lhs and doctests.hsc copy&pasteable across wider set of packages. It starts to look good already.

@phadej
Copy link
Collaborator Author

phadej commented Jan 13, 2017

Thanks for the rights!

So you are ok with not testing stack.yaml in Travis? (then it might make sense to use only single one, for the dev)

@phadej
Copy link
Collaborator Author

phadej commented Jan 13, 2017

Sorry for the spam. But I'd wait with this until Ben & Ryan are commented on this (in other repos PR, distributive), before continuing with this.

I'm also not 100% sure that non-released Cabal api won't change, but I guess it's still ok to push this to Hackage as setup-depends are in place.

@fizruk
Copy link
Owner

fizruk commented Jan 17, 2017

@phadej where's the discussion this is blocked on?

@phadej
Copy link
Collaborator Author

phadej commented Jan 17, 2017

I pushed a commit, if it's green with 8.2, then feel free to merge

@fizruk fizruk merged commit cf75536 into fizruk:master Jan 17, 2017
@fizruk
Copy link
Owner

fizruk commented Jan 17, 2017

Great! Thanks!

@phadej phadej deleted the ghc-8.2 branch January 17, 2017 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure with GHC HEAD
2 participants