Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cookie-0.5 #137

Closed
wants to merge 1 commit into from
Closed

Conversation

spencerjanssen
Copy link
Contributor

No description provided.

@phadej
Copy link
Collaborator

phadej commented Apr 30, 2024

The changelog for cookie-0.5 says

This is a breaking change, as it changes the behavior of parseCookies and parseSetCookie to no longer include the surrounding double quotes in the cookie value. This is the correct behavior according to the RFC.

And we do use parseSetCookie. Have you verified that things still work?

@spencerjanssen
Copy link
Contributor Author

I did run the test suite, yes. Reasonable uses of the API provided by cookie or http-api-data will not break. According to the RFC user agents may optionally wrap the cookie value in double quotes.

I think we are also covered by the disclaimer attached to the instances for SetCookie:

/Note:/ this instance works correctly for alphanumeric name and value

I can add a note about this in the changelog if you'd like.

@phadej
Copy link
Collaborator

phadej commented Apr 30, 2024

Yes, I think it's better to do a separate release for this, i.e. not just a "silent" Hackage revision.

@spencerjanssen
Copy link
Contributor Author

Sounds good. I can add a changelog entry. Shall I include a minor version bump up to 0.6.1 as well?

@phadej
Copy link
Collaborator

phadej commented Apr 30, 2024

Shall I include a minor version bump up to 0.6.1 as well?

Please do.

@spencerjanssen
Copy link
Contributor Author

Done, thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants