Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change toEncodedUrlPiece to encode any url piece #123

Closed
wants to merge 1 commit into from

Conversation

cblp
Copy link

@cblp cblp commented Nov 1, 2022

This function is used in Servant as the query param encoder, but encodePathSegmentsRelative encodes '+' wrongly when used in query parameters.

This function is used in Servant as the query param encoder, but encodePathSegmentsRelative encodes '+' wrongly when used in query parameters.
@phadej
Copy link
Collaborator

phadej commented Nov 2, 2022

See #119 which did the same wrong thing.

See #120 for correct solution.

@fizruk
Copy link
Owner

fizruk commented Nov 6, 2022

Closed in favour of #120.

@fizruk fizruk closed this Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants