Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape reserved symbols in default implementation of toEncodedUrlPiece #119

Closed
wants to merge 1 commit into from
Closed

Escape reserved symbols in default implementation of toEncodedUrlPiece #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/Web/Internal/HttpApiData.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ class ToHttpApiData a where
-- The default definition uses 'H.encodePathSegmentsRelative',
-- but this may be overriden with a more efficient version.
toEncodedUrlPiece :: a -> BS.Builder
toEncodedUrlPiece = H.encodePathSegmentsRelative . (:[]) . toUrlPiece
toEncodedUrlPiece = H.urlEncodeBuilder True . encodeUtf8 . toUrlPiece

-- | Convert to HTTP header value.
toHeader :: a -> ByteString
Expand Down Expand Up @@ -514,7 +514,7 @@ instance ToHttpApiData DayOfWeek where

toEncodedUrlPiece = unsafeToEncodedUrlPiece

-- |
-- |
-- >>> toUrlPiece Q4
-- "q4"
instance ToHttpApiData QuarterOfYear where
Expand Down Expand Up @@ -865,5 +865,3 @@ runAtto :: Atto.Parser a -> Text -> Either Text a
runAtto p t = case Atto.parseOnly (p <* Atto.endOfInput) t of
Left err -> Left (T.pack err)
Right x -> Right x