-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add passthrough columns to card model. #81
feat: add passthrough columns to card model. #81
Conversation
181fbc8
to
f3c7c6e
Compare
f3c7c6e
to
f2d3ac7
Compare
Thanks @bramrodenburg for opening this! Looks great. One question - Regarding
Actually, second question -- are there downstream models in the stripe transform package you'd want these passthrough columns to persist to? Such as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and runs great, just a couple of documentation-related suggestions, and see above questions ^
Co-authored-by: Jamie Rodriguez <[email protected]>
I didn't include it in our tests. We asked Stripe at the time to enable the
At the moment not. Thanks for asking :)
Committed your documentation-related suggestions! |
Woo thank you! This looks great to me. I'm going to merge it into a release branch to make some other changes and CI tests. Many thanks |
* feat: add passthrough columns to card model. (#81) * feat: add non-standard columns to card model. * implement feedback from issue * Apply suggestions from code review Co-authored-by: Jamie Rodriguez <[email protected]> --------- Co-authored-by: Jamie Rodriguez <[email protected]> * polishes * docs * explain metadata better * link * try something out * revert * changelog * test out removing code block * revert and use yaml isntead of yml --------- Co-authored-by: bramrodenburg <[email protected]>
Please provide your name and company
Bram - Gigs
Link the issue/feature request which this PR is meant to address
#80
Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
Add passthrough variables for the
stg_stripe__card
model. This can, for example, be used to pull in non-standard columns from Stripe such asdescription
,iin
andissuer
.How did you validate the changes introduced within this PR?
Followed the instructions here and tested the changes against our own internal data. Note, I could only do this for
iin
andissuer
, not fordescription
.Which warehouse did you use to develop these changes?
BigQuery
Did you update the CHANGELOG?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Typically there are additional maintenance changes required before this will be ready for an upcoming release. Are you comfortable with the Fivetran team making a few commits directly to your branch?
If you had to summarize this PR in an emoji, which would it be?
🐸
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.
PR Template
Community Pull Request Template (default)
Maintainer Pull Request Template (to be used by maintainers)