-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new models and fields #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-reneeli thanks for putting together this PR. I have a few requests for this to be updated. Let me know if you have any questions on my comments below.
Additionally, it seems the README needs to be updated to reflect the new version of the package following this release.
Lastly, it looks like dispute
and transfer
are not being found when running integration tests. This is likely a result of some of my comments that need to be addressed.
…o i updated the macro to force cast as boolean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look great to me! I do have a few final requests and questions. Would you be able to address those and then regenerate the docs. Once that is complete this will be good to be approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look great to me!
PR Overview
This PR will address the following Issue/Feature: n/a
This PR will result in the following new package version: v 11
Not breaking, but significant upgrades to our Stripe package for Q3 2023.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
Confirm that these additions appear in the target schema when run
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
💃