Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributor/fee test update #65

Merged
merged 7 commits into from
Apr 17, 2023

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz commented Apr 13, 2023

PR Overview

This PR will address the following Issue/Feature: #63

This PR will result in the following new package version: v0.9.2

This is only changing the uniqueness test of the stg_stripe__fee model. Additionally, as this model is not used in any downstream transformations, I feel extra confident that this will not result in a breaking change.

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

This PR is an extension of the contributor PR #64

This PR includes a new field index being added to the stg_stripe__fee model. This field was already included in the get_fee_columns macro and the seed files. As such, this was a relatively easy addition to the staging model. This field was primarily added to ensure we can appropriately test the unique combination of columns for the fee staging model. As a fee can have multiple indexes, we need to account for this accordingly within our package.

Additionally, you can see in our own Stripe ERD that index is included in the composite PK. As such, we should account for this accordingly.
image

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt compile
  • dbt run –full-refresh
  • dbt run
  • dbt test
  • dbt run –vars (if applicable)

Before marking this PR as “ready for review” the following have been applied:

  • The appropriate issue has been linked and tagged
  • You are assigned to the corresponding issue and this PR
  • BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as “ready for review”:

  • You have validated these changes and assure this PR will address the respective Issue/Feature.
  • You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
  • You have provided details below around the validation steps performed to gain confidence in these changes.

In addition to running the compile, run, and test commands, I also tested these changes along with the current live version of the dbt_stripe package to ensure there would be no downstream impacts. As the stg_stripe__fee model is not connected to any downstream models, I am very confident this will not caused any issues. Additionally, I was able to verify from the docs and our own ERD that index should in fact be counted towards the uniqueness of the fee staging model.

Standard Updates

Please acknowledge that your PR contains the following standard updates:

  • Package versioning has been appropriately indexed in the following locations:
    • indexed within dbt_project.yml
    • indexed within integration_tests/dbt_project.yml
  • CHANGELOG has individual entries for each respective change in this PR
  • README updates have been applied (if applicable)
  • DECISIONLOG updates have been updated (if applicable)
  • Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

  • docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

🐾

@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review April 13, 2023 18:26
Copy link

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 4be5791 into main Apr 17, 2023
@fivetran-joemarkiewicz fivetran-joemarkiewicz deleted the contributor/fee-test-update branch April 17, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants