Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: #63
This PR will result in the following new package version:
v0.9.2
This is only changing the uniqueness test of the
stg_stripe__fee
model. Additionally, as this model is not used in any downstream transformations, I feel extra confident that this will not result in a breaking change.Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
This PR is an extension of the contributor PR #64
This PR includes a new field
index
being added to thestg_stripe__fee
model. This field was already included in theget_fee_columns
macro and the seed files. As such, this was a relatively easy addition to the staging model. This field was primarily added to ensure we can appropriately test the unique combination of columns for the fee staging model. As a fee can have multiple indexes, we need to account for this accordingly within our package.Additionally, you can see in our own Stripe ERD that index is included in the composite PK. As such, we should account for this accordingly.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as “ready for review” the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as “ready for review”:
In addition to running the compile, run, and test commands, I also tested these changes along with the current live version of the dbt_stripe package to ensure there would be no downstream impacts. As the
stg_stripe__fee
model is not connected to any downstream models, I am very confident this will not caused any issues. Additionally, I was able to verify from the docs and our own ERD that index should in fact be counted towards the uniqueness of the fee staging model.Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🐾