Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata extraction pivot #61

Merged
merged 4 commits into from
Apr 5, 2023

Conversation

LewisDavies
Copy link
Contributor

Are you a current Fivetran customer?

Lewis Davies, Prisma

What change(s) does this PR introduce?

My Stripe data has metadata columns in the card and invoice_line_items. I've added the metadata extraction macro to these models.

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

  • Yes, Issue/Feature [link bug/feature number here]
  • No

How did you test the PR changes?

  • BuildKite
  • Local (please provide additional testing details below)

I added the relevant variables to my project and built the changed models locally. In my Stripe data card didn't have any values in metadata, but I was able to extract successfully extract values from invoice_line_item.

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

💃

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@LewisDavies
Copy link
Contributor Author

FYI @fivetran-joemarkiewicz

@fivetran-joemarkiewicz
Copy link
Contributor

Hi @LewisDavies thanks for bumping this! Our new sprint just started yesterday. I will review this as part of it 😄

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LewisDavies thanks so much for contributing this feature request to the Stripe package! I feel this will be beneficial for all users and will be something we can integrate into the next patch release.

I made a few updates to your branch that are required on our end prior to merging into main. With those changes I will approve and kick off our internal release process. You can expect this to be live early next week. Additionally, let me know if you have any questions regarding my latest commit updates.

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit d72caea into fivetran:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants