-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Union schema compatibility #30
Conversation
Note--updated fivetran_utils.union_data to account for pinterest naming exceptions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving these changes with the stipulation of the upstream pinterest_source updates being applied and approved. In addition there are a few notes below I would like you to address before rolling out these updates along with the others.
Issue: #29
Confirm the following files were correctly updated automatically:
window functions (partition by)Manual updates:
source_relation
to downstream models if necessarysource_relation
in unique-combination-of-cols if necessaryValidation:
dbt run
locally passesdbt test
locally passes