feature/v2-updates

[fivetran-joemarkiewicz]

Are you a current Fivetran customer?

Fivetran created PR

What change(s) does this PR introduce?

This PR includes the following updates:

• Addition of the following new models:
  • pinterest_ads__advertiser_report
  • pinterest_ads__campaign_report
  • pinterest_ads__ad_group_report
  • pinterest_ads__keyword_report
  • pinterest_ads__pin_promotion_report
  • pinterest_ads__url_report
• Added testing for each end model to ensure granularity and accuracy of the modeled data.
• README and yml documentation updates

Did you update the CHANGELOG?

• Yes

Does this PR introduce a breaking change?

• Yes (please provide breaking change details below.)
• No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

• Yes

Is this PR in response to a previously created Bug or Feature Request

• Yes, will also close out Issue FEATURE - Include Account Name in Output Models #16
• No

How did you test the PR changes?

• CircleCi
• Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

• BigQuery
• Redshift
• Snowflake
• Postgres
• Databricks
• Other (provide details below)

Provide an emoji that best describes your current mood

🏊‍♂️

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

[fivetran-sheringuyen]

Hey @fivetran-joemarkiewicz, awesome PR!

I left some in-line notes and had a couple of questions:

• In this package, I noticed in the .yml file that sometimes you do a DOCS reference for a definition and sometimes you have the definition explicitly in the .yml, is there a reason for that? E.g. some campaign_id fields will have the definition and some will refer to DOCS.
• Can you talk a little as to why there's a non_null test for date_day across your models?
• Looks like similar to the source package, you can close PR Feature/advertiser addition #19 as well as delete the branch for spark :)

[fivetran-joemarkiewicz]

Thanks for the review @fivetran-sheringuyen! I was able to address your inline comments and see below for my responses to your broader questions:

In this package, I noticed in the .yml file that sometimes you do a DOCS reference for a definition and sometimes you have the definition explicitly in the .yml, is there a reason for that? E.g. some campaign_id fields will have the definition and some will refer to DOCS.

• This was an oversight on my part. I didn't update the previous docs to use the docs.md I created from the source. I just updated the previous descriptions to fit with the standard across models of using the docs.md when available.

Can you talk a little as to why there's a non_null test for date_day across your models?

• Following our team discussions. I added the not null tests to the day and lowest grain fields to ensure data completeness.

Looks like similar to the source package, you can close PR #19 as well as delete the branch for spark :)

• For sure! I closed the PR and deleted the stale branch.

[fivetran-sheringuyen]

Awesome work, thanks for the updates @fivetran-joemarkiewicz !