Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/email send idi #26

Merged
merged 7 commits into from
Aug 24, 2022
Merged

Bugfix/email send idi #26

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
05f941d
versioning
fivetran-reneeli Aug 19, 2022
58816f9
update surr key to include primary attribute value
fivetran-reneeli Aug 19, 2022
463ec98
fix version-- not a breaking change
fivetran-reneeli Aug 19, 2022
fa47893
update changelog
fivetran-reneeli Aug 19, 2022
d2e425a
update email send id for all
fivetran-reneeli Aug 23, 2022
533a776
Update CHANGELOG.md
fivetran-reneeli Aug 23, 2022
19c0193
commit issue
fivetran-reneeli Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# dbt_marketo_source v0.7.2
## Bug Fixes
- Updated surrogate key `email_send_id` to include `primary_attribute_value_id`. The previous key was at a campaign level grain, not an email level grain. This is pertinent in the case where there are multiple emails that part of the same campaign. (https://github.com/fivetran/dbt_marketo_source/issues/25)
fivetran-reneeli marked this conversation as resolved.
Show resolved Hide resolved
[#26](https://github.com/fivetran/dbt_marketo_source/pull/26)
## Contributors
- [sfc-gh-sugupta](https://github.com/sfc-gh-sugupta)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link the issue @sfc-gh-sugupta originally created. This was we can see their contribution since it is not a direct commit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this wasn't added. Would you be able to link the issue next to the account name

# dbt_marketo_source v0.7.1

## Bug Fixes
Expand Down
2 changes: 1 addition & 1 deletion dbt_project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'marketo_source'
version: '0.7.1'
version: '0.7.2'
config-version: 2
require-dbt-version: [">=1.0.0", "<2.0.0"]

Expand Down
2 changes: 1 addition & 1 deletion integration_tests/dbt_project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'marketo_source_integration_tests'
version: '0.7.1'
version: '0.7.2'
profile: 'integration_tests'
config-version: 2

Expand Down
2 changes: 1 addition & 1 deletion models/stg_marketo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ models:
description: The choice number of the current step that triggered the activity.

- name: email_send_id
description: The inferred ID for the email sent.
description: The inferred ID for the email sent. This is created by concatenating primary_attribute_value_id, campaign_id, campaign_run_id, and lead_id.

- name: email_template_id
description: The ID of the email's template.
Expand Down
2 changes: 1 addition & 1 deletion models/stg_marketo__activity_send_email.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ with base as (

select
*,
{{ dbt_utils.surrogate_key(['campaign_id','campaign_run_id','lead_id']) }} as email_send_id
{{ dbt_utils.surrogate_key(['primary_attribute_value_id','campaign_id','campaign_run_id','lead_id']) }} as email_send_id
from fields

)
Expand Down