Skip to content

Commit

Permalink
Merge pull request #1 from fivetran/kristin_review
Browse files Browse the repository at this point in the history
Minor edits
  • Loading branch information
kristin-bagnall authored Jun 3, 2020
2 parents b8bccac + 813a406 commit 3ccd988
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 24 deletions.
6 changes: 6 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
target/
dbt_modules/
logs/
keyfile.json
.DS_Store
develop/
20 changes: 10 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@

This package models Marketo data from [Fivetran's connector](https://fivetran.com/docs/applications/marketo). It uses data in the format described by [this ERD](https://docs.google.com/presentation/d/1TauFmnr89QV1KV_Un7kJ-KJWOQt1fbp59a1xJLUdDDY/edit).

This package is designed enrich your Fivetran data by doing the following:
This package enriches your Fivetran data by doing the following:

* Add descriptions to tables and columns that are synced using Fivetran
* Add column-level testing where applicable. For example, all primary keys are tested for uniqueness and non-null values.
* Model staging tables, which will be used in our transform package
* Adds descriptions to tables and columns that are synced using Fivetran
* Adds column-level testing where applicable. For example, all primary keys are tested for uniqueness and non-null values.
* Models staging tables, which will be used in our transform package

## Models

This package contains staging models, designed to work simultaneously with our [Marketo modeling package](https://github.com/fivetran/dbt_marketo). The staging models are designed to:
This package contains staging models, designed to work simultaneously with our [Marketo modeling package](https://github.com/fivetran/dbt_marketo). The staging models:

* Remove any rows that are soft-deleted
* Name columns consistently across all packages:
Expand All @@ -19,10 +19,10 @@ This package contains staging models, designed to work simultaneously with our [
* ID primary keys are prefixed with the name of the table. For example, the user table's ID column is renamed user_id.

## Installation Instructions
Check [dbt Hub](https://hub.getdbt.com/) for the latest installation instructions, or [read the docs](https://docs.getdbt.com/docs/package-management) for more information on installing packages.
Check [dbt Hub](https://hub.getdbt.com/) for the latest installation instructions, or [read the dbt docs](https://docs.getdbt.com/docs/package-management) for more information on installing packages.

## Configuration
By default this package will look for your Marketo data in the `marketo` schema of your [target database](https://docs.getdbt.com/docs/running-a-dbt-project/using-the-command-line-interface/configure-your-profile). If this is not where your Marketo data is, please add the following configuration to your `dbt_project.yml` file:
By default this package will look for your Marketo data in the `marketo` schema of your [target database](https://docs.getdbt.com/docs/running-a-dbt-project/using-the-command-line-interface/configure-your-profile). If this is not where your Marketo data is, add the following configuration to your `dbt_project.yml` file:

```yml
# dbt_project.yml
Expand All @@ -44,10 +44,10 @@ or open PRs against `master`. Check out
on the best workflow for contributing to a package.

## Resources:
- Learn more about Fivetran [here](https://fivetran.com/docs)
- Learn more about Fivetran [in the Fivetran docs](https://fivetran.com/docs)
- Check out [Fivetran's blog](https://fivetran.com/blog)
- Learn more about dbt [in the docs](https://docs.getdbt.com/docs/introduction)
- Learn more about dbt [in the dbt docs](https://docs.getdbt.com/docs/introduction)
- Check out [Discourse](https://discourse.getdbt.com/) for commonly asked questions and answers
- Join the [chat](http://slack.getdbt.com/) on Slack for live discussions and support
- Find [dbt events](https://events.getdbt.com) near you
- Check out [the blog](https://blog.getdbt.com/) for the latest news on dbt's development and best practices
- Check out [the dbt blog](https://blog.getdbt.com/) for the latest news on dbt's development and best practices
14 changes: 1 addition & 13 deletions dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,22 +1,10 @@

name: 'marketo_source'
version: '1.0.0'
version: '0.0.1'

require-dbt-version: '>=0.17.0'
config-version: 2

source-paths: ["models"]
analysis-paths: ["analysis"]
test-paths: ["tests"]
data-paths: ["data"]
macro-paths: ["macros"]
snapshot-paths: ["snapshots"]

target-path: "target" # directory which will store compiled SQL files
clean-targets: # directories to be removed by `dbt clean`
- "target"
- "dbt_modules"

vars:
marketo_source:
lead: "{{ source('marketo','lead') }}"
Expand Down
2 changes: 1 addition & 1 deletion models/src_marketo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: 2

sources:
- name: marketo
schema: "{{ var('marketo_schema', marketo) }}"
schema: "{{ var('marketo_schema', 'marketo') }}"
database: "{{ var('marketo_database', target.database) }}"

tables:
Expand Down

0 comments on commit 3ccd988

Please sign in to comment.