Bug/databricks syntax #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: fivetran-catfritz <[email protected]>
fivetran-joemarkiewicz
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
@fivetran-catfritz great job working through this PR! I do still feel like there is some more around the Marketo data model we need to understand better. Would you be able to open a FR for us to explore the data model in more detail and determine if we need to rework any of the logic.
Regardless, these changes look good to me! Let's merge these into the release branch and ensure they will work with the next release changes. If they do, we can move forward with starting the release process.
Comment on lines
+2
to
+6
| # version: [">=0.11.0", "<0.12.0"] | ||
| - git: https://github.com/fivetran/dbt_marketo_source.git | ||
| revision: update/customer360 | ||
| warn-unpinned: false |
There was a problem hiding this comment.
Reminder to swap before release
fivetran-catfritz
added a commit
that referenced
this pull request
Apr 2, 2024
* document default LEAD columns (#32) * changes * docs * changelog * update source package ref * Update CHANGELOG.md Co-authored-by: fivetran-catfritz <[email protected]> * changelog --------- Co-authored-by: fivetran-catfritz <[email protected]> * Bug/databricks syntax (#33) * changes * docs * changelog * update source package ref * Update CHANGELOG.md Co-authored-by: fivetran-catfritz <[email protected]> * changelog * bug/databricks-syntax * update pkg * update cte * remove ignore nulls * updates * updates & regen docs * update yml --------- Co-authored-by: Jamie Rodriguez <[email protected]> * Update packages.yml --------- Co-authored-by: Jamie Rodriguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature:
#31
This PR will result in the following new package version:
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
If you had to summarize this PR in an emoji, which would it be?
💃