feature/api-updates #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
fivetran-joemarkiewicz
requested changes
Jul 11, 2023
There was a problem hiding this comment.
@fivetran-catfritz thanks for working through this PR! I only have a few small comments on this PR. My main questions and suggestions are in the source PR. There will likely only be a few minor updates to this PR. But wanted to hold of approving until the source was in a ready state as well.
Let me know if you have any questions!
README.md
Outdated
| - name: "a_second_field" | ||
| transform_sql: "cast(a_second_field as string)" | ||
| # a similar pattern can be applied to the rest of the following variables. | ||
| marketo__lead_passthrough_columns: |
There was a problem hiding this comment.
See my comment from the source package. I would recommend possibly removing this variable to make the user experience more seamless.
packages.yml
Outdated
Comment on lines
2
to
7
| # version: [">=0.10.0", "<0.11.0"] | ||
|
|
||
| - git: https://github.com/fivetran/dbt_marketo_source.git | ||
| revision: feature/api-updates | ||
| warn-unpinned: false |
There was a problem hiding this comment.
Obligatory reminder to update before merging.
fivetran-joemarkiewicz
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: fivetran/dbt_marketo_source#32
This PR will result in the following new package version:
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
Standard Updates
Please acknowledge that your PR contains the following standard updates:
DECISIONLOG updates have been updated (if applicable)dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
💃