Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/duplicate deleted lead ids #26

Merged
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# dbt_marketo v0.9.1

## Bug Fix
[PR #26](https://github.com/fivetran/dbt_marketo/pull/26) includes the following non-breaking change:
- Due to a "system glitch" within Marketo, the same `lead_id` can be deleted more than once. This may introduce multiple records for the same `lead_id` in the `int_marketo__lead` which can cause the downstream test `marketo__leads.lead_id.unique` to fail. The bug fix adds a `distinct lead_id` to the `deleted_leads` CTE in the `int_marketo__lead` model (https://github.com/fivetran/dbt_marketo/issues/25).
fivetran-joemarkiewicz marked this conversation as resolved.
Show resolved Hide resolved

m-feeser marked this conversation as resolved.
Show resolved Hide resolved
# dbt_marketo v0.9.0

## 🚨 Breaking Changes 🚨:
Expand Down
2 changes: 1 addition & 1 deletion dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'marketo'
version: '0.9.0'
version: '0.9.1'
config-version: 2
require-dbt-version: [">=1.3.0", "<2.0.0"]
on-run-start: "{{ lead_history_columns_warning() }}"
Expand Down
2 changes: 1 addition & 1 deletion integration_tests/dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'marketo_integration_tests'
version: '0.9.0'
version: '0.9.1'
profile: 'integration_tests'
config-version: 2

Expand Down
2 changes: 1 addition & 1 deletion models/intermediate/int_marketo__lead.sql
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ to False. Default is True*/
{% if var('marketo__activity_delete_lead_enabled', True) %}
), deleted_leads as (

select *
select distinct lead_id
from {{ var('activity_delete_lead') }}

{% endif %}
Expand Down