Merge pull request #26 from m-feeser/bug/duplicate-deleted-lead-ids

Bug/duplicate deleted lead ids
fivetran · Jan 17, 2023 · 5cf1a68 · 5cf1a68
2 parents 181ab5e + 4605e36
commit 5cf1a68
Show file tree

Hide file tree

Showing 8 changed files with 16 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,12 @@
+# dbt_marketo v0.9.1
+
+## Bug Fix
+[PR #26](https://github.com/fivetran/dbt_marketo/pull/26) includes the following non-breaking change:
+- Due to a "system glitch" within Marketo, the same `lead_id` can be deleted more than once. This may introduce multiple records for the same `lead_id` in the `int_marketo__lead` which can cause the downstream test `marketo__leads.lead_id.unique` to fail.  The bug fix adds a `distinct lead_id` to the `deleted_leads` CTE in the `int_marketo__lead` model (https://github.com/fivetran/dbt_marketo/issues/25). 
+
+## Contributors
+ - [@m-feeser](https://github.com/m-feeser) ([#26](https://github.com/fivetran/dbt_marketo/pull/26))
+
 # dbt_marketo v0.9.0
 
 ## 🚨 Breaking Changes 🚨:

diff --git a/dbt_project.yml b/dbt_project.yml
@@ -1,5 +1,5 @@
 name: 'marketo'
-version: '0.9.0'
+version: '0.9.1'
 config-version: 2
 require-dbt-version: [">=1.3.0", "<2.0.0"]
 on-run-start: "{{ lead_history_columns_warning() }}"

diff --git a/docs/catalog.json b/docs/catalog.json
diff --git a/docs/index.html b/docs/index.html
diff --git a/docs/manifest.json b/docs/manifest.json
diff --git a/docs/run_results.json b/docs/run_results.json
diff --git a/integration_tests/dbt_project.yml b/integration_tests/dbt_project.yml
@@ -1,5 +1,5 @@
 name: 'marketo_integration_tests'
-version: '0.9.0'
+version: '0.9.1'
 profile: 'integration_tests'
 config-version: 2
 

diff --git a/models/intermediate/int_marketo__lead.sql b/models/intermediate/int_marketo__lead.sql
@@ -22,7 +22,7 @@ to False. Default is True*/
 {% if var('marketo__activity_delete_lead_enabled', True) %}
 ), deleted_leads as (
 
-    select *
+    select distinct lead_id
     from {{ var('activity_delete_lead') }}
 
 {% endif %}