Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added buffer variable documentation #115

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Conversation

fivetran-avinash
Copy link
Contributor

@fivetran-avinash fivetran-avinash commented Jan 10, 2024

PR Overview

This PR will address the following Issue/Feature: [#112]

This PR will result in the following new package version:

No new package version, updates formally announced when jira calendar spine fixes are validated

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

CHANGELOG will not change, documentation for this update will appear in the next version of the dbt_jira package

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • [NA] dbt run –full-refresh && dbt test
  • [NA] dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • [NA] The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • [NA] docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • [NA] Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:
Documentation update

If you had to summarize this PR in an emoji, which would it be?

⌨️

@fivetran-avinash fivetran-avinash self-assigned this Jan 10, 2024
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! No release needed, feel free to merge to main

@fivetran-avinash fivetran-avinash merged commit 4a8cec1 into main Jan 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants