Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in database_variable #7

Merged
merged 3 commits into from
Dec 15, 2022
Merged

Fix typo in database_variable #7

merged 3 commits into from
Dec 15, 2022

Conversation

dougpm
Copy link
Contributor

@dougpm dougpm commented Dec 12, 2022

Pull Request
Are you a current Fivetran customer?
Douglas, Data Engineer at Pattern Brands

What change(s) does this PR introduce?
Fix a typo in the custom database variable.

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

  • Yes, Issue/Feature [link bug/feature number here]
  • No

How did you test the PR changes?

  • CircleCi
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

💃

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-joemarkiewicz fivetran-joemarkiewicz changed the base branch from main to MagicBot/dbt-utils-cross-db-migration December 15, 2022 15:20
Copy link
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dougpm thanks so much for catching this bug! We are actually in the process of rolling out our dbt-utils migrations at the moment. I will plan to incorporate your change into these migration updates. You should be able to see the next release be reflected during the week of 1/3!

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit f70dbfb into fivetran:MagicBot/dbt-utils-cross-db-migration Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants