Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/conversions #21

Merged
merged 10 commits into from
Oct 29, 2024
Merged

Feature/conversions #21

merged 10 commits into from
Oct 29, 2024

Conversation

fivetran-reneeli
Copy link
Contributor

@fivetran-reneeli fivetran-reneeli commented Oct 1, 2024

PR Overview

This PR will address the following Issue/Feature:
Adding conversion metrics

This PR will result in the following new package version:

v0.4.0

breaking change to users who weren't bringing in conversion metrics already through the passthrough variable.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Feature update: Conversion Support

  • We have added conversion metrics to the following staging models:

    • ad_group_level_report
    • advertised_product_report
    • campaign_level_report
    • targeting_keyword_report
    • search_term_ad_keyword_report
  • The conversion metrics are the following:

    • purchases_30_d: Number of attributed conversion events occurring within 30 days of an ad click.
    • sales_30_d: Total value of sales occurring within 30 days of an ad click.

Under the hood: Backwards compatibility

  • In the event that you were already passing the above fields in via our passthrough columns, the package will dynamically avoid "duplicate column" errors.
  • This was done via the new google_ads_fill_pass_through_columns and google_ads_add_pass_through_columns macros to ensure that the new conversion fields are backwards compatible with users who have already included them via passthrough fields.

The above new field additions are 🚨 breaking changes 🚨 for users who were not already bringing in conversion fields via passthrough columns.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • [na] The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

If you had to summarize this PR in an emoji, which would it be?

💃

Copy link
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dbt-databricks>=1.6.0,<2.0.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question about if there is a reason this is different than the other versions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no real reason -- I just noticed this was inconsistent with some other packages and updated it accordingly. I can revert this if preferable!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this is okay to keep, I just wanted to make sure there wasn't a specific reason and if we needed to adjust our dbt required version for this update. All good to keep. Thanks!

@fivetran-jamie fivetran-jamie merged commit 650b083 into main Oct 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants