-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/conversions #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dbt-databricks>=1.6.0,<2.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question about if there is a reason this is different than the other versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no real reason -- I just noticed this was inconsistent with some other packages and updated it accordingly. I can revert this if preferable!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No this is okay to keep, I just wanted to make sure there wasn't a specific reason and if we needed to adjust our dbt required version for this update. All good to keep. Thanks!
PR Overview
This PR will address the following Issue/Feature:
Adding conversion metrics
This PR will result in the following new package version:
v0.4.0
breaking change to users who weren't bringing in conversion metrics already through the passthrough variable.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Feature update: Conversion Support
We have added conversion metrics to the following staging models:
The conversion metrics are the following:
purchases_30_d
: Number of attributed conversion events occurring within 30 days of an ad click.sales_30_d
: Total value of sales occurring within 30 days of an ad click.Under the hood: Backwards compatibility
google_ads_fill_pass_through_columns
andgoogle_ads_add_pass_through_columns
macros to ensure that the new conversion fields are backwards compatible with users who have already included them via passthrough fields.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
If you had to summarize this PR in an emoji, which would it be?
💃