Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map fly to selected area #14

Merged
merged 5 commits into from
Feb 28, 2024
Merged

Map fly to selected area #14

merged 5 commits into from
Feb 28, 2024

Conversation

fityannugroho
Copy link
Owner

PR Checklist

Please check if your PR fulfills the following requirements:

Put [x] to check

  • I have read the documentation.
  • I have read and followed the Contributing Guidelines.
  • I have included a pull request description of my changes.
  • I have included the necessary changes to the documentation.
  • I have added tests to cover my changes.

PR Type

What kind of change does this PR introduce?

Please check any kind of changes that applies to this PR using [x]

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

Issue Number: N/A

Currently, when an area is selected, user need to drag (and zoom) the map to see the area clearly by itself.

What is the new behavior?

  • Now, the map will fly (move and zoom) to the selected area automatically.
  • Change the show/hide boundary feature (now only change the boundary color to hide it, it doesn't removed from the components hierarchy).
  • Disable the child's ComboboxArea when the boundary data of its parent is loading.
  • Show loading spinner besides the boundary switch, when the boundary data is loading.

Other information

None

@fityannugroho fityannugroho added the enhancement New feature or request label Feb 28, 2024
Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
idn-area-map ✅ Ready (Inspect) Visit Preview Feb 28, 2024 7:20am

@fityannugroho fityannugroho merged commit 8204fd2 into main Feb 28, 2024
4 checks passed
@fityannugroho fityannugroho deleted the feat/fly-to-area branch February 28, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant