Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix quotes " escaping in CommandItem component #10

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Conversation

fityannugroho
Copy link
Owner

@fityannugroho fityannugroho commented Feb 11, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Put [x] to check

  • I have read the documentation.
  • I have read and followed the Contributing Guidelines.
  • I have included a pull request description of my changes.
  • I have included the necessary changes to the documentation.
  • I have added tests to cover my changes.

PR Type

What kind of change does this PR introduce?

Please check any kind of changes that applies to this PR using [x]

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • ..... (describe the other type)

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

Issue Number:

Error when the value of CommandItem component contains quotes ".

CommandItem component is a Ref component from cmdk's Command.Item component.

What is the new behavior?

Escape all quotes " in value as a temporary fix.

Other information

Revert this changes when there is a patch update from cmdk. Current version: 0.2.1

Revert this when pacocoursey/cmdk#189 is fixed, and upgrade the `cmdk` dependency
@fityannugroho fityannugroho added the bug Something isn't working label Feb 11, 2024
Copy link

vercel bot commented Feb 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
idn-area-map ✅ Ready (Inspect) Visit Preview Feb 11, 2024 11:37pm

@fityannugroho fityannugroho merged commit 48c6fa8 into main Feb 11, 2024
4 checks passed
@fityannugroho fityannugroho deleted the fix/cmdk branch February 11, 2024 23:40
@fityannugroho fityannugroho changed the title fix quotes " issue in CommandItem component fix quotes " escaping in CommandItem component Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant