fix quotes "
escaping in CommandItem
component
#10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number:
DOMException
if selector contains unescaped quotes pacocoursey/cmdk#189querySelector
issue introduced in 0.2.1 pacocoursey/cmdk#212Error when the
value
ofCommandItem
component contains quotes"
.CommandItem
component is a Ref component fromcmdk
'sCommand.Item
component.What is the new behavior?
Escape all quotes
"
invalue
as a temporary fix.Other information
Revert this changes when there is a patch update from
cmdk
. Current version:0.2.1