[SU-490]Adelanto de pago con período de gracia / Repayment with Grace… #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Period(ensure only the first installment is penalty-graced)
oluexpert99
requested review from
faheem205,
tabrez-fiter,
fiter-julius-oketayot and
felixonen97
faheem205
requested changes
Dec 7, 2024
There was a problem hiding this comment.
@oluexpert99 as discussed on slack in sumas channel, first installment in arrears will be eligible for grace and not installment # 1
fiter-julius-oketayot
approved these changes
Dec 8, 2024
… Period(ensure only the first installment is penalty-graced)
faheem205
requested changes
Dec 8, 2024
...va/org/apache/fineract/portfolio/loanaccount/service/LoanChargeWritePlatformServiceImpl.java
Show resolved
Hide resolved
… Period(ensure only the first installment is penalty-graced)
faheem205
approved these changes
Dec 9, 2024
Napho
pushed a commit
that referenced
this pull request
Dec 24, 2024
Bug fixes and modifications Related work items: #1327, #1333, #1338, #1339, #1340, #1343, #1344, #1345, #1347, #1348, #1349, #1350, #1351, #1352, #1353, #1354, #1355, #1356, #1357, #1358, #1361, #1362, #1363, #1364, #1365, #1366, #1367, #1368, #1369, #1371, #1374, #1375, #1381, #1382, #1383, #1384, #1385, #1388, #1391, #29692
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SU-490]Adelanto de pago con período de gracia / Repayment with Grace Period(ensure only the first installment is penalty-graced)
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.