FBR-460 bypass prequalification check for bulk import (#332)

Co-authored-by: Faheem Ahmad <[email protected]>
fiterlatam · Dec 12, 2023 · 8e04abd · 8e04abd
1 parent b3fd143
commit 8e04abd
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/...a/org/apache/fineract/infrastructure/bulkimport/importhandler/loan/LoanImportHandler.java b/...a/org/apache/fineract/infrastructure/bulkimport/importhandler/loan/LoanImportHandler.java
@@ -556,6 +556,7 @@ private CommandProcessingResult importLoan(int rowIndex, String dateFormat) {
             }
         }
         loanJsonOb.remove("isTopup");
+        loanJsonOb.addProperty("isBulkImport", true);
         String payload = loanJsonOb.toString();
         final CommandWrapper commandRequest = new CommandWrapperBuilder() //
                 .createLoanApplication() //

diff --git a/...fineract/portfolio/loanaccount/serialization/LoanApplicationCommandFromApiJsonHelper.java b/...fineract/portfolio/loanaccount/serialization/LoanApplicationCommandFromApiJsonHelper.java
@@ -99,7 +99,7 @@ public final class LoanApplicationCommandFromApiJsonHelper {
             LoanApiConstants.lastApplication, // glim specific
             LoanApiConstants.daysInYearTypeParameterName, LoanApiConstants.fixedPrincipalPercentagePerInstallmentParamName,
             LoanApiConstants.cupoIdParameterName, LoanApiConstants.PREQUALIFICATION_ID, LoanApiConstants.CASE_ID,
-            LoanApiConstants.LOAN_ADDITIONAL_DATA, "borrowerCycle"));
+            LoanApiConstants.LOAN_ADDITIONAL_DATA, "borrowerCycle", "isBulkImport"));
 
     private final FromJsonHelper fromApiJsonHelper;
     private final CalculateLoanScheduleQueryFromApiJsonHelper apiJsonHelper;

diff --git a/...ovider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanAssembler.java b/...ovider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanAssembler.java
@@ -348,11 +348,15 @@ private Loan assembleApplication(final JsonElement element, final Long clientId,
             }
         }
 
-        final Long prequalificationId = this.fromApiJsonHelper.extractLongNamed("prequalificationId", element);
-        final PrequalificationGroup prequalificationGroup = this.prequalificationGroupRepositoryWrapper
-                .findOneWithNotFoundDetection(prequalificationId);
-        if (!PrequalificationStatus.BURO_CHECKED.getValue().equals(prequalificationGroup.getStatus())) {
-            throw new PrequalificationIncorrectStatusException(PrequalificationStatus.fromInt(prequalificationGroup.getStatus()).getCode());
+        PrequalificationGroup prequalificationGroup = null;
+        final Boolean isBulkImport = this.fromApiJsonHelper.extractBooleanNamed("isBulkImport", element);
+        if (isBulkImport == null || !isBulkImport) {
+            final Long prequalificationId = this.fromApiJsonHelper.extractLongNamed("prequalificationId", element);
+            prequalificationGroup = this.prequalificationGroupRepositoryWrapper
+                    .findOneWithNotFoundDetection(prequalificationId);
+            if (!PrequalificationStatus.BURO_CHECKED.getValue().equals(prequalificationGroup.getStatus())) {
+                throw new PrequalificationIncorrectStatusException(PrequalificationStatus.fromInt(prequalificationGroup.getStatus()).getCode());
+            }
         }
         loanApplicationTerms = this.loanScheduleAssembler.assembleLoanTerms(element);
         loanApplicationTerms.getCalculatedRepaymentsStartingFromLocalDate();