forked from FITER1/community-app-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FBR-609 #329
Merged
Merged
Fix FBR-609 #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliuspetero
approved these changes
Feb 21, 2024
BrianMuhimbura
approved these changes
Feb 22, 2024
leonardohildt
added a commit
that referenced
this pull request
Feb 22, 2024
* Bug/FBR-592: Reporte de Netsuite no esta funcionando (#315) * fix FBR 594 * Enhancements/FBR-597-FBR-596: Hard Policy Check Fixes (#317) * Enhancement/FBR-589: Link Prequalification to client view page (#318) * fix FBR 599 * Fix translations (#320) * Update editloanaccount.html (#321) * Updated spanish translations (#322) * Bug/FBR-592: Fix java.io.IOException: Broken pipe v3 (#324) * fix FBR 599 * fix fbr 606 * fix fbr 606 * Feature/FBR-588: Personalizar asientos contables (#328) * Fix FBR-609 (#329) --------- Co-authored-by: Muhimbura Brian Mart <brianmigel@gmail.com> Co-authored-by: Leonardo Hildt <108893281+leonardohildt@users.noreply.github.com>
fiterlatam
pushed a commit
that referenced
this pull request
May 1, 2024
* fiter/fb/qa: (138 commits) Latest bug fixes Release/1.0.33 prepare (#359) Release/1.0.32 prepare (#357) Release/1.0.31 prepare (#355) Release v1.0.30 (#353) Release v1.0.29 (#346) QA - Release/1.0.28 prepare (#344) fix fbr 612 fix fbr 542 Release guarantee extra fields Enhancement/FBR-593: Traducir valores y etiquetas en solicitud de préstamo (#332) fix fbr 536 QA - Release/1.0.27 prepare (#330) Fix FBR-609 (#329) Feature/FBR-588: Personalizar asientos contables (#328) fix fbr 606 fix fbr 606 fix FBR 599 Bug/FBR-592: Fix java.io.IOException: Broken pipe v3 (#324) QA Release 1.0.26 prepare (#323) ...
leonardohildt
added a commit
that referenced
this pull request
May 1, 2024
* additionals for group loans * Bug/Fix Invalid individual loan requested amount (#212) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * FBR 489 * Bug/FBR-488: Approve/Reject Loan Request Fixes (#216) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * Bug/FBR-488: Approve/Reject Loan Request Fixes V4 (#217) * Update upload size configuration for nginx (#219) * Fix FBR-483 - update permission name * Updated default.conf.template file (#221) * Feature/FBR-418: Add Additional Loan Properties (#211) * Feature/FBR-418: Add Additional Loan Properties * Feature/FBR-418: Add Additional Loan Properties --------- Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * Update Docker file (#222) * Updated default conf template (#223) * FBR 417 * FBR 417 * FBR 417 * FBR-493: Adjust prequalification workflows (#226) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * FBR 417 * Feature/FBR-420: Optimize Loan Additional Information (#224) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * FBR-393 Commas for thousands and points for decimals * Upload Documents * FBR 472 * Feature/FBR-420: Add Hard Policy Checks V1 (#229) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * FBR 487 * FBR 471 * FBR 491 * Fix Prequalification substatus * FBR-482/FBR-492: Edit Prequalifications (#235) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * Fix Prequalification substatus * Fix Prequalification substatus (#237) * Bug/FBR-482: Remove unwanted code (#238) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * fix/FBR-419 * fix/FBR-419 * FBR-482: Fix Prequalification Date Of Birth Date Picker (#240) * FBR-000: Fix Prequalification Date Of Birth Date Picker * FBR-482: Fix Prequalification Date Of Birth Date Picker --------- Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * fix/FBR-453 * fix/FBR-453 * Fbr 453 (#241) * fix/FBR-453 * fix/FBR-453 * fix/FBR-417 * Feature/FBR-418: Solicitud de crédito individual - Agregar pestaña para campos adicionales en nuevo préstamo (#242) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * FBR-429 update loan restructuring to outstanding principal amount * Feature/FBR-420: Refactor hard-policy implementation Final (#245) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * fix/FBR-417 * fix/FBR-417 * Bug/FBR-435-502-509: Fix Reported Bugs (#247) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * fix/FBR-417 * fix/FBR-417 (#248) * Bugs/FBR-510-FBR-418: Bug Fixes (#249) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * fix/FBR-508 * fix/FBR-484 * FBR-490-FBR-492: Prequalify Button Fixes (#252) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * Bug/FBR-490: Préstamo complementario - Waive Interest (#253) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * Bug/FBR-424-FBR-507: Prequalification and Group bug fixes (#254) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * fix/FBR-515 * Bug/FBR-490: Prequalification fixes (#257) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * Missing translation * Missing translation (#258) * Enhancements/FBR-517: Adjust the names for features related to checks (#260) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * fix cheque assignment to available cheques * FIX FBR 523 * FIX FBR 538 * FIX FBR 538 * Fixes for spanish translations * FIX FBR 534 * FIX FBR 534 * Release/1.0.19 prepare (#267) * additionals for group loans * Bug/Fix Invalid individual loan requested amount (#212) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * FBR 489 * Bug/FBR-488: Approve/Reject Loan Request Fixes (#216) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * Bug/FBR-488: Approve/Reject Loan Request Fixes V4 (#217) * Update upload size configuration for nginx (#219) * Fix FBR-483 - update permission name * Updated default.conf.template file (#221) * Feature/FBR-418: Add Additional Loan Properties (#211) * Feature/FBR-418: Add Additional Loan Properties * Feature/FBR-418: Add Additional Loan Properties --------- Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * Update Docker file (#222) * Updated default conf template (#223) * FBR 417 * FBR 417 * FBR 417 * FBR-493: Adjust prequalification workflows (#226) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * FBR 417 * Feature/FBR-420: Optimize Loan Additional Information (#224) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * FBR-393 Commas for thousands and points for decimals * Upload Documents * FBR 472 * Feature/FBR-420: Add Hard Policy Checks V1 (#229) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * FBR 487 * FBR 471 * FBR 491 * Fix Prequalification substatus * FBR-482/FBR-492: Edit Prequalifications (#235) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * Fix Prequalification substatus * Fix Prequalification substatus (#237) * Bug/FBR-482: Remove unwanted code (#238) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * fix/FBR-419 * fix/FBR-419 * FBR-482: Fix Prequalification Date Of Birth Date Picker (#240) * FBR-000: Fix Prequalification Date Of Birth Date Picker * FBR-482: Fix Prequalification Date Of Birth Date Picker --------- Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * fix/FBR-453 * fix/FBR-453 * Fbr 453 (#241) * fix/FBR-453 * fix/FBR-453 * fix/FBR-417 * Feature/FBR-418: Solicitud de crédito individual - Agregar pestaña para campos adicionales en nuevo préstamo (#242) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * FBR-429 update loan restructuring to outstanding principal amount * Feature/FBR-420: Refactor hard-policy implementation Final (#245) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * fix/FBR-417 * fix/FBR-417 * Bug/FBR-435-502-509: Fix Reported Bugs (#247) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * fix/FBR-417 * fix/FBR-417 (#248) * Bugs/FBR-510-FBR-418: Bug Fixes (#249) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * fix/FBR-508 * fix/FBR-484 * FBR-490-FBR-492: Prequalify Button Fixes (#252) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * Bug/FBR-490: Préstamo complementario - Waive Interest (#253) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * Bug/FBR-424-FBR-507: Prequalification and Group bug fixes (#254) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * fix/FBR-515 * Bug/FBR-490: Prequalification fixes (#257) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * Missing translation * Missing translation (#258) * Enhancements/FBR-517: Adjust the names for features related to checks (#260) Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> * fix cheque assignment to available cheques * FIX FBR 523 * FIX FBR 538 * FIX FBR 538 * Fixes for spanish translations --------- Co-authored-by: Muhimbura Brian Mart <brianmigel@gmail.com> Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> Co-authored-by: Leonardo Hildt <108893281+leonardohildt@users.noreply.github.com> Co-authored-by: Leonardo Hildt <leonardo@fiter.io> Co-authored-by: Faheem Ahmad <faheem@fiter.io> Co-authored-by: Faheem Ahmad <faheem205@gmail.com> Co-authored-by: Faheem Ahmad <faheemahmad@sanmar.com> * Enhancement/Bugs: Contingency fixes * add columns to reasign cheques view * Bug/Fix failing docker build * 427 * 427 * FBR- * FBR- * FBR-532 * FBR-531 * fix/FBR-530 * fix/FBR-530 * Fbr 536 redesign guaratee (#276) * Feature/FBR-536: Redesign of payment guarantees by checks * Feature/FBR-536: Redesign of payment guarantees by checks * FBR-545 Add Range and day in center description * 1.0.21 prepare (#280) * Fbr 536 redesign guaratee (#276) * Feature/FBR-536: Redesign of payment guarantees by checks * Feature/FBR-536: Redesign of payment guarantees by checks * FBR-545 Add Range and day in center description --------- Co-authored-by: Faheem Ahmad <faheemahmad@sanmar.com> Co-authored-by: Faheem Ahmad <faheem205@gmail.com> * v1.0.20-alpha-fb release * Fbr 555 report filters (#281) * Feature/FBR-555: Optimize report filter * Feature/FBR-555: Optimize report filter * Feature/FBR-555: Optimize report filter - v2 (#283) * Feature/FBR-555: Optimize report filter - v3 * FBR-547 * Featire/FBR-552: Buro check messag message (#286) * release 1.0.22 * Fix created date display prequalification * Enhancement/FBR-554: Payments job - English transalation (#290) * Bugs/FBR-527,FBR-524,FBR-552: UAT Fixes * Release v1.0.22-alpha-fb (#292) * Enhancement/FBR-554: Payments job - English transalation (#290) * Bugs/FBR-527,FBR-524,FBR-552: UAT Fixes --------- Co-authored-by: Brian Muhimbura <brianmigel@gmail.com> * Feature/FBR-543: Add portfolio search by name (#293) * Bugs/FBR-564: Fix edit maiden name * modify last payment release guarantee amount * Bugs/FBR-564: Fix edit maiden name * Bugs/FBR-564: Fix edit maiden name * Bugs/FBR-564,FBR-565: Independientemente del estado del prestamo, debe poder ser cerrado el prestamo. * disable loan cycle * fix fbr 427 * fix fbr 427 * fix fbr 560 * fix fbr 427 * fix fbr 427 * FBR-575: Mostrar un filtro para seleccionar la cartera (#304) * Enhancements/FBR-579: Standardize the format in the amounts (#305) * fix fbr 427 * Enhancements/FBR-581: Add Spanish Translations (#307) * Update capital letter for label header (#308) * Update capital letter for label header * Update locale-es.json * fix fbr 578 * Release/1.0.25 prepare (#310) * FBR-575: Mostrar un filtro para seleccionar la cartera (#304) * Enhancements/FBR-579: Standardize the format in the amounts (#305) * fix fbr 427 * Enhancements/FBR-581: Add Spanish Translations (#307) * Update capital letter for label header (#308) * Update capital letter for label header * Update locale-es.json * fix fbr 578 --------- Co-authored-by: Muhimbura Brian Mart <brianmigel@gmail.com> Co-authored-by: Leonardo Hildt <108893281+leonardohildt@users.noreply.github.com> * show closed clients on group view * Form validation on loan creation * Enhancements/FBR-591: Translate titles to Spanish * Bug/FBR-592: Reporte de Netsuite no esta funcionando (#315) * fix FBR 594 * Enhancements/FBR-597-FBR-596: Hard Policy Check Fixes (#317) * Enhancement/FBR-589: Link Prequalification to client view page (#318) * fix FBR 599 * Fix translations (#320) * Update editloanaccount.html (#321) * Updated spanish translations (#322) * QA Release 1.0.26 prepare (#323) * Bug/FBR-592: Reporte de Netsuite no esta funcionando (#315) * fix FBR 594 * Enhancements/FBR-597-FBR-596: Hard Policy Check Fixes (#317) * Enhancement/FBR-589: Link Prequalification to client view page (#318) * fix FBR 599 * Fix translations (#320) * Update editloanaccount.html (#321) * Updated spanish translations (#322) --------- Co-authored-by: Muhimbura Brian Mart <brianmigel@gmail.com> Co-authored-by: Leonardo Hildt <108893281+leonardohildt@users.noreply.github.com> * Bug/FBR-592: Fix java.io.IOException: Broken pipe v3 (#324) * fix FBR 599 * fix fbr 606 * fix fbr 606 * Feature/FBR-588: Personalizar asientos contables (#328) * Fix FBR-609 (#329) * QA - Release/1.0.27 prepare (#330) * Bug/FBR-592: Reporte de Netsuite no esta funcionando (#315) * fix FBR 594 * Enhancements/FBR-597-FBR-596: Hard Policy Check Fixes (#317) * Enhancement/FBR-589: Link Prequalification to client view page (#318) * fix FBR 599 * Fix translations (#320) * Update editloanaccount.html (#321) * Updated spanish translations (#322) * Bug/FBR-592: Fix java.io.IOException: Broken pipe v3 (#324) * fix FBR 599 * fix fbr 606 * fix fbr 606 * Feature/FBR-588: Personalizar asientos contables (#328) * Fix FBR-609 (#329) --------- Co-authored-by: Muhimbura Brian Mart <brianmigel@gmail.com> Co-authored-by: Leonardo Hildt <108893281+leonardohildt@users.noreply.github.com> * fix fbr 536 * Enhancement/FBR-593: Traducir valores y etiquetas en solicitud de préstamo (#332) * Release guarantee extra fields * fix fbr 542 * fix fbr 612 * QA - Release/1.0.28 prepare (#344) * Improvements/FBR-615: Schedular Jobs Improvements (#337) * Edit loan application validatoins * new loan application current loans validation * Improvements/FBR-615: Schedular Jobs Improvements - V2 (#341) * Update locale-es.json (#342) * Bugs/FBR-597-FBR-596-FBR-576: Refactor Hard Policy Checks (#343) --------- Co-authored-by: Muhimbura Brian Mart <brianmigel@gmail.com> Co-authored-by: Leonardo Hildt <108893281+leonardohildt@users.noreply.github.com> * Release v1.0.29 (#346) * Improvements/FBR-615: Schedular Jobs Improvements (#337) * Edit loan application validatoins * new loan application current loans validation * Improvements/FBR-615: Schedular Jobs Improvements - V2 (#341) * Update locale-es.json (#342) * Bugs/FBR-597-FBR-596-FBR-576: Refactor Hard Policy Checks (#343) * fix fbr 617 --------- Co-authored-by: fiter-julius-oketayot <140818859+fiter-julius-oketayot@users.noreply.github.com> Co-authored-by: Muhimbura Brian Mart <brianmigel@gmail.com> * Release v1.0.30 (#353) * Improvements/FBR-615: Schedular Jobs Improvements (#337) * Edit loan application validatoins * new loan application current loans validation * Improvements/FBR-615: Schedular Jobs Improvements - V2 (#341) * Update locale-es.json (#342) * Bugs/FBR-597-FBR-596-FBR-576: Refactor Hard Policy Checks (#343) * fix fbr 617 * fix fbr 626 * Fix FBR-623 - add missing translations (#347) * Fix FBR-625 Additional fields in loan request is not saving the value of Actividad Económica * fix fbr 627 * Update locale-es.json (#351) * Added spanish translations (#352) --------- Co-authored-by: fiter-julius-oketayot <140818859+fiter-julius-oketayot@users.noreply.github.com> Co-authored-by: Muhimbura Brian Mart <brianmigel@gmail.com> * Release/1.0.31 prepare (#355) * Improvements/FBR-615: Schedular Jobs Improvements (#337) * Edit loan application validatoins * new loan application current loans validation * Improvements/FBR-615: Schedular Jobs Improvements - V2 (#341) * Update locale-es.json (#342) * Bugs/FBR-597-FBR-596-FBR-576: Refactor Hard Policy Checks (#343) * fix fbr 617 * fix fbr 626 * Fix FBR-623 - add missing translations (#347) * Fix FBR-625 Additional fields in loan request is not saving the value of Actividad Económica * fix fbr 627 * Update locale-es.json (#351) * Added spanish translations (#352) * fix FBR-247 --------- Co-authored-by: fiter-julius-oketayot <140818859+fiter-julius-oketayot@users.noreply.github.com> Co-authored-by: Muhimbura Brian Mart <brianmigel@gmail.com> * Release/1.0.32 prepare (#357) * Improvements/FBR-615: Schedular Jobs Improvements (#337) * Edit loan application validatoins * new loan application current loans validation * Improvements/FBR-615: Schedular Jobs Improvements - V2 (#341) * Update locale-es.json (#342) * Bugs/FBR-597-FBR-596-FBR-576: Refactor Hard Policy Checks (#343) * fix fbr 617 * fix fbr 626 * Fix FBR-623 - add missing translations (#347) * Fix FBR-625 Additional fields in loan request is not saving the value of Actividad Económica * fix fbr 627 * Update locale-es.json (#351) * Added spanish translations (#352) * fix FBR-247 * fix fbr 632 --------- Co-authored-by: fiter-julius-oketayot <140818859+fiter-julius-oketayot@users.noreply.github.com> Co-authored-by: Muhimbura Brian Mart <brianmigel@gmail.com> * Release/1.0.33 prepare (#359) * Improvements/FBR-615: Schedular Jobs Improvements (#337) * Edit loan application validatoins * new loan application current loans validation * Improvements/FBR-615: Schedular Jobs Improvements - V2 (#341) * Update locale-es.json (#342) * Bugs/FBR-597-FBR-596-FBR-576: Refactor Hard Policy Checks (#343) * fix fbr 617 * fix fbr 626 * Fix FBR-623 - add missing translations (#347) * Fix FBR-625 Additional fields in loan request is not saving the value of Actividad Económica * fix fbr 627 * Update locale-es.json (#351) * Added spanish translations (#352) * fix FBR-247 * fix fbr 632 * Fix export for csv related to the planning (#358) --------- Co-authored-by: fiter-julius-oketayot <140818859+fiter-julius-oketayot@users.noreply.github.com> Co-authored-by: Muhimbura Brian Mart <brianmigel@gmail.com> * Latest bug fixes --------- Co-authored-by: Muhimbura Brian Mart <brianmigel@gmail.com> Co-authored-by: fiter-julius-oketayot <140818859+fiter-julius-oketayot@users.noreply.github.com> Co-authored-by: Julius Peter Oketayot <juliuspeter441@gmail.com> Co-authored-by: Faheem Ahmad <faheem@fiter.io> Co-authored-by: Faheem Ahmad <faheem205@gmail.com> Co-authored-by: Faheem Ahmad <faheemahmad@sanmar.com> Co-authored-by: Julius Peter Oketayot <julius@fiter.io> Co-authored-by: Julius Peter Oketayot <juliuspetero@outlook.com>
fiterlatam
pushed a commit
that referenced
this pull request
May 10, 2024
* fiter/fb/qa: (139 commits) merge qa fix FBR 657 Latest bug fixes Release/1.0.33 prepare (#359) Release/1.0.32 prepare (#357) Release/1.0.31 prepare (#355) Release v1.0.30 (#353) Release v1.0.29 (#346) QA - Release/1.0.28 prepare (#344) fix fbr 612 fix fbr 542 Release guarantee extra fields Enhancement/FBR-593: Traducir valores y etiquetas en solicitud de préstamo (#332) fix fbr 536 QA - Release/1.0.27 prepare (#330) Fix FBR-609 (#329) Feature/FBR-588: Personalizar asientos contables (#328) fix fbr 606 fix fbr 606 fix FBR 599 Bug/FBR-592: Fix java.io.IOException: Broken pipe v3 (#324) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made instead of how they were made.
Related issues and discussion
#{Issue Number}
Screenshots, if any
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Validate the JS and HTML files with
grunt validate
to detect errors and potential problems in JavaScript code.Run the tests by opening
test/SpecRunner.html
in the browser to make sure you didn't break anything.If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
community-app/Contributing.md
.