Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Middleware version to QueueItem entity #361

Open
14 of 15 tasks
TSchmiedlechner opened this issue Nov 13, 2024 · 3 comments · Fixed by #368
Open
14 of 15 tasks

Add Middleware version to QueueItem entity #361

TSchmiedlechner opened this issue Nov 13, 2024 · 3 comments · Fixed by #368
Assignees
Labels
enhancement New feature or request

Comments

@TSchmiedlechner
Copy link
Member

TSchmiedlechner commented Nov 13, 2024

Context

Currently, we cannot know in retrospective which version of the Middleware processed a QueueItem. Knowing this would be very practical though, e.g. in reports and also to make specific features (for example in exports) based on this version.

Solution

We will add a new field to the ftQueueItem entity, both in the Middleware's local storages as well as in our Azure storage. The field will be set to the full version of the current Middleware, e.g. 1.3.45 or 1.3.45-rc1-123123-12312321.

Tasks

  • Add a new nullable string field ProcessingVersion to ftQueueItem entity in the fiskaltrust.storage package
  • Add the updated package to the Middleware and update the Storage implementations and the migrations
    • SQLite
    • Azure Storage
    • MySQL
    • EF
    • PostgreSQL
  • Update the package in Helipad and write the incoming fields to the account storage.
    • Ensure that the field is nullable and old MW versions that don't send the field can still upload
    • End2End test (i.e. create receipts and verify them in the storage)
  • Test with..
    • Launcher 1.3
    • Launcher 2.0
    • Android
    • BYODC/CloudCashbox
@TSchmiedlechner TSchmiedlechner added the enhancement New feature or request label Nov 13, 2024
@volllly
Copy link
Contributor

volllly commented Nov 14, 2024

Do we also want this for 1.2?

We need to make sure the queue assembly version detection works in all our launchers (1.3, 2.0, androud, byodc, cloudcashbox).

@TSchmiedlechner
Copy link
Member Author

@volllly Good point with the testing, added tasks for this 👍🏻

I don't think that I would add this to 1.2, the benefit seems pretty limited to me there as anyone nobody is updating their MW 🤔 what do you think?

@volllly
Copy link
Contributor

volllly commented Nov 14, 2024

👍 I guess this will anyways need to be nullable since we don't have it for historic data so it's no problem if we don't have it for 1.2

@TSchmiedlechner TSchmiedlechner assigned pawelvds and unassigned pawelvds Nov 14, 2024
@pawelvds pawelvds self-assigned this Nov 18, 2024
forsthug added a commit that referenced this issue Nov 27, 2024
pawelvds added a commit that referenced this issue Nov 27, 2024
…ueueItem-entity' into #361-Add-Middleware-version-to-QueueItem-entity
@volllly volllly linked a pull request Nov 29, 2024 that will close this issue
4 tasks
pawelvds added a commit that referenced this issue Dec 2, 2024
…to-QueueItem-entity

#361 - Add Middleware version to QueueItem entity
@pawelvds pawelvds reopened this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants