Skip to content

Commit

Permalink
Github Actions: Remove --disable-tests
Browse files Browse the repository at this point in the history
With --disable-tests, for example for Go the `make check` under `lib/go`
would only run unit tests under `lib/go/thrift` but not the unit tests
under `lib/go/test`.
  • Loading branch information
fishy committed Nov 22, 2023
1 parent a06eedc commit da69e1f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
1 change: 0 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ env:
BUILD_DEPS: automake bison flex git libboost-all-dev libevent-dev libssl-dev libtool make pkg-config
CONFIG_ARGS_FOR_LIBS: >
--disable-debug
--disable-tests
--disable-dependency-tracking
--without-cpp
--without-c_glib
Expand Down
9 changes: 7 additions & 2 deletions lib/go/test/fuzz/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,15 @@
# under the License.
#


# Starting from go 1.21 `go mod init` will generate the go line as:
# go 1.21.4
# which will require the go.mod at this directory to have a matching version,
# so use sed to get rid of the patch version.
gopathfuzz: $(THRIFT) fuzz.go
$(THRIFT) -r --gen go:thrift_import=github.com/apache/thrift/lib/go/thrift$(COMPILER_EXTRAFLAG) ../../../../tutorial/tutorial.thrift
cd gen-go/shared && go mod init shared
cd gen-go/tutorial && go mod init tutorial
cd gen-go/shared && go mod init shared && sed 's/^go 1\.\([0-9]*\).*$$/go 1.\1/g' go.mod > go.mod.new && mv go.mod.new go.mod
cd gen-go/tutorial && go mod init tutorial && sed 's/^go 1\.\([0-9]*\).*$$/go 1.\1/g' go.mod > go.mod.new && mv go.mod.new go.mod
touch gopathfuzz

check: gopathfuzz
Expand Down

0 comments on commit da69e1f

Please sign in to comment.