fish-food name and script name look like they need to be identical

[scranton]

I created a script called gloo-ctl.lua with an internal name of "local name = 'glooctl'" as that's the executable name. I can install and uninstall gloo-ctl correctly, but when I do a gofish upgrade I get this error.

Error: open /usr/local/Fish/Rigs/github.com/fishworks/fish-food/Food/glooctl.lua: no such file or directory

Feels like there's an assumption somewhere that script name matches exec name.

[bacongobbler]

Good catch. Yes, there is an underlying assumption that the name of the file in the repository and the food's name are identical. In the future, gofish create glooctl should set this up properly. :)

In the meantime, would you mind PR'ing a fix to glooctl to rename the file to glooctl.lua? That should get things rolling again for you.

[bacongobbler]

Perhaps we should have gofish lint catch that case as well.

[scranton]

Will do tomorrow. Thanks! You may want to think about an enhancement to allow for different names if for no other reason than muscle memory from homebrew. Kubernetes-ctl -> kubectl etc. someday you’ll hit name conflicts and then script writers will be forced to hack in a exec-name variable or such. Not that big a deal I guess. Defiantly need to have lint catch this, and a comment in the Template about value assumptions would be really helpful. Thanks for the nice tool! Scott

…

On Thu, Feb 28, 2019 at 11:09 PM Matthew Fisher ***@***.***> wrote: Perhaps we should have gofish lint catch that case as well. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#124 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYWV1Fs5EfhwaEE8i7noBMOgeeprbv6ks5vSKgJgaJpZM4bYO76> .