This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
[RTC-556] Only set turn servers once #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
force-pushed
the
turnconfig
branch
3 times, most recently
from
25f3355 to
e8f8ff4
Compare
mickel8
changed the title
mironiasty
pushed a commit
that referenced
this pull request
Jun 20, 2024
* Fix screenshare state being lost on disconnect * Add `autoStreaming` and `preview` options to screenshare * Run prettier
kamil-stasiak
approved these changes
Jun 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So far, whenever we received offerData, we were pushing turnServers to our internal
rtcConfigarray, which is also passed to the PeerConnection at its creation time.Motivation and Context
Setting them just at the beginning should be enough. We would also prevent from memory leak. It's also hard to determine whether rtcConfig array can be safely modified throught session time.
Types of changes
not work as expected)