This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Standardize configuration files across Fishjam JS repos #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balins
force-pushed
the
jb/standardize-js-repos
branch
from
May 24, 2024 09:19
bb88799
to
94f2ec2
Compare
mironiasty
reviewed
May 27, 2024
package-lock.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using yarn
in other repose, so I think this file should be replaced with yarn.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've been using yarn
only in react-native-client-sdk
, other use npm
. But we can migrate all repos to use yarn
if you wish.
balins
force-pushed
the
jb/standardize-js-repos
branch
5 times, most recently
from
May 27, 2024 14:56
bf76bc5
to
1f6afb7
Compare
balins
force-pushed
the
jb/standardize-js-repos
branch
from
May 27, 2024 15:00
1f6afb7
to
5b8c727
Compare
balins
force-pushed
the
jb/standardize-js-repos
branch
from
May 27, 2024 15:06
5b8c727
to
b416be1
Compare
mironiasty
approved these changes
May 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of JS repositories standardization process, which is to ensure all JS repositories have a similar set of scripts, same TS version, prettier config etc.