This repository has been archived by the owner on Sep 19, 2024. It is now read-only.
Live compositor #291
Merged
Live compositor #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rados13
reviewed
Jul 10, 2023
Comment on lines
56
to
63
| @impl true | ||
| def handle_inputs_change( | ||
| inputs, | ||
| _ctx, | ||
| %{screenShare?: true} = state | ||
| ) do | ||
| {inputs, state} | ||
| end |
There was a problem hiding this comment.
Shouldn't it be modified? Because if I understand correctly, it won't even work, because inputs aren't a Scene struct?
There was a problem hiding this comment.
it should have been removed but I missed it
Comment on lines
+90
to
+139
| defp get_desired_stream_format(1, output_stream_format) do | ||
| output_stream_format | ||
| end | ||
|
|
||
| defp get_desired_stream_format(2, %{width: width, height: height}) do | ||
| %{ | ||
| width: round(1 / 2 * width) - @padding * 2, | ||
| height: height - @padding * 2 | ||
| } | ||
| end | ||
|
|
||
| defp get_desired_stream_format(3, %{width: width, height: height}) do | ||
| %{ | ||
| width: round(1 / 2 * width) - @padding * 2, | ||
| height: round(1 / 2 * height) - @padding * 2 | ||
| } | ||
| end | ||
|
|
||
| defp get_placement(desired_stream_format, 1, 0, input_stream_format, _output_stream_format) do | ||
| %BaseVideoPlacement{ | ||
| position: {0, 0}, | ||
| size: scale(desired_stream_format, input_stream_format), | ||
| z_value: @z_value | ||
| } | ||
| end | ||
|
|
||
| defp get_placement(desired_stream_format, 2, index, input_stream_format, %{width: width}) do | ||
| %BaseVideoPlacement{ | ||
| position: {round(1 / 2 * width) * index + @padding, @padding}, | ||
| size: scale(desired_stream_format, input_stream_format), | ||
| z_value: @z_value | ||
| } | ||
| end | ||
|
|
There was a problem hiding this comment.
Whay do you think about moving these functions on the end of the file?
Comment on lines
167
to
201
| defp get_cropping(desired_stream_format, scaled_stream_format), | ||
| do: %Cropping{ | ||
| crop_top_left_corner: get_cropping_position(desired_stream_format, scaled_stream_format), | ||
| crop_size: get_cropping_size(desired_stream_format, scaled_stream_format), | ||
| cropped_video_position: :input_position | ||
| } | ||
|
|
||
| defp get_cropping_position(desired_stream_format, {width, height}) do | ||
| if desired_stream_format.width == width, | ||
| do: {0.0, (height - desired_stream_format.height) / (2 * height)}, | ||
| else: {(width - desired_stream_format.width) / (2 * width), 0.0} | ||
| end | ||
|
|
||
| defp get_cropping_size(desired_stream_format, {width, height}) do | ||
| if desired_stream_format.width == width, | ||
| do: {1.0, desired_stream_format.height / height}, | ||
| else: {desired_stream_format.width / width, 1.0} | ||
| end |
There was a problem hiding this comment.
What do you think about creating a utils module where these functions could be moved?
There was a problem hiding this comment.
This file is around 200 lines so I don't think that we have to split it into smaller parts.
Karolk99
force-pushed
the
live-compositor
branch
from
bdb76a6
to
a09c5da
Compare
Codecov Report
@@ Coverage Diff @@
## master #291 +/- ##
==========================================
+ Coverage 62.91% 63.11% +0.20%
==========================================
Files 44 40 -4
Lines 2130 2055 -75
==========================================
- Hits 1340 1297 -43
+ Misses 790 758 -32
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Karolk99
force-pushed
the
live-compositor
branch
2 times, most recently
from
42abd54
to
1827c5a
Compare
Rados13
reviewed
Jul 11, 2023
Rados13
approved these changes
Jul 11, 2023
mickel8
approved these changes
Jul 11, 2023
Karolk99
force-pushed
the
live-compositor
branch
2 times, most recently
from
d8e4de7
to
481bb6d
Compare
Karolk99
force-pushed
the
live-compositor
branch
from
481bb6d
to
e39e79f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.