Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

Fix to_type_string/1 for 3rd party endpoints #285

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Fix to_type_string/1 for 3rd party endpoints #285

merged 1 commit into from
Jun 23, 2023

Conversation

mickel8
Copy link
Contributor

@mickel8 mickel8 commented Jun 22, 2023

see #284

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #285 (8c52239) into master (1e87c76) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
+ Coverage   62.92%   62.94%   +0.01%     
==========================================
  Files          44       44              
  Lines        2131     2129       -2     
==========================================
- Hits         1341     1340       -1     
+ Misses        790      789       -1     
Impacted Files Coverage Δ
...embrane_rtc_engine/endpoints/webrtc/media_event.ex 22.85% <0.00%> (+0.63%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e87c76...8c52239. Read the comment docs.

@mickel8 mickel8 force-pushed the fix-type branch 2 times, most recently from 80b2a7e to cc313a3 Compare June 23, 2023 10:47
@mickel8 mickel8 changed the title Fix endpoint type to string Fix to_type_string/1 for 3rd party endpoints Jun 23, 2023
@mickel8 mickel8 changed the title Fix to_type_string/1 for 3rd party endpoints Fix to_type_string/1 for 3rd party endpoints Jun 23, 2023
@mickel8 mickel8 marked this pull request as ready for review June 23, 2023 10:49
@mickel8 mickel8 merged commit c21eeb9 into master Jun 23, 2023
@mickel8 mickel8 deleted the fix-type branch June 23, 2023 12:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants