Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

[RTC-258][RTC-259] Fix overflow in Tee tests. Fix RC in VAD Tee test. #272

Merged
merged 5 commits into from
May 31, 2023
Merged

[RTC-258][RTC-259] Fix overflow in Tee tests. Fix RC in VAD Tee test. #272

merged 5 commits into from
May 31, 2023

Conversation

Rados13
Copy link
Contributor

@Rados13 Rados13 commented May 25, 2023

No description provided.

@Rados13 Rados13 requested a review from mickel8 as a code owner May 25, 2023 10:49
@codecov
Copy link

codecov bot commented May 25, 2023 •
edited
Loading

Codecov Report

Merging #272 (b58f1df) into master (ab0f451) will decrease coverage by 0.24%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
- Coverage   62.68%   62.44%   -0.24%     
==========================================
  Files          43       44       +1     
  Lines        2093     2093              
==========================================
- Hits         1312     1307       -5     
- Misses        781      786       +5
Impacted Files Coverage Δ
test/support/fake_rtsp_server.ex 92.20% <ø> (-1.48%) ⬇️
test/support/precise_realtimer.ex 94.44% <94.44%> (ø)

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0f451...b58f1df. Read the comment docs.

@Rados13 Rados13 self-assigned this May 25, 2023
@Rados13 Rados13 force-pushed the RTC-258-rtc-engine-tee-test-correctly-forwards-variants-failed branch from 8e4ee73 to 5221fb8 Compare May 25, 2023 15:25
@Rados13 Rados13 requested a review from sgfn as a code owner May 25, 2023 15:25
mickel8
mickel8 reviewed May 25, 2023
View reviewed changes
Copy link
Contributor

@mickel8 mickel8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, instead of using activate_source, let's send buffer manually

@Rados13 Rados13 requested a review from mickel8 May 26, 2023 09:24
mickel8
mickel8 suggested changes May 26, 2023
View reviewed changes
test/membrane_rtc_engine/tee_test.exs Show resolved Hide resolved
test/membrane_rtc_engine/tee_test.exs Show resolved Hide resolved
test/membrane_rtc_engine/tee_test.exs Outdated Show resolved Hide resolved
sgfn
sgfn reviewed May 29, 2023
View reviewed changes
Copy link
Member

@sgfn sgfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if @mickel8 approves you're good to go

@Rados13 Rados13 requested a review from mickel8 May 30, 2023 07:13
@mickel8 mickel8 changed the title Add RTPRealtimer [RTC-258] Fix overflow in Tee tests May 30, 2023
@mickel8 mickel8 changed the title [RTC-258] Fix overflow in Tee tests [RTC-258][RTC-259] Fix overflow in Tee tests. Fix RC in VAD Tee test. May 30, 2023
@Rados13 Rados13 requested a review from sgfn May 31, 2023 05:31
@mickel8 mickel8 force-pushed the RTC-258-rtc-engine-tee-test-correctly-forwards-variants-failed branch from b58f1df to f2bafd3 Compare May 31, 2023 07:21
@mickel8 mickel8 merged commit d1f7a1b into master May 31, 2023
@mickel8 mickel8 deleted the RTC-258-rtc-engine-tee-test-correctly-forwards-variants-failed branch May 31, 2023 07:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mickel8 mickel8 mickel8 approved these changes

@sgfn sgfn Awaiting requested review from sgfn sgfn is a code owner

Assignees

@Rados13 Rados13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rados13 @mickel8 @sgfn