Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

Refactor hls tests (remove sleep()) #245

Merged
merged 7 commits into from
Feb 27, 2023
Merged

Refactor hls tests (remove sleep()) #245

merged 7 commits into from
Feb 27, 2023

Conversation

Karolk99
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@1620023). Click here to learn what that means.
The diff coverage is 94.11%.

@@            Coverage Diff            @@
##             master     #245   +/-   ##
=========================================
  Coverage          ?   57.67%           
=========================================
  Files             ?       38           
  Lines             ?     1786           
  Branches          ?        0           
=========================================
  Hits              ?     1030           
  Misses            ?      756           
  Partials          ?        0           
Impacted Files Coverage Δ
lib/membrane_rtc_engine/engine.ex 74.28% <ø> (ø)
..._rtc_engine/endpoints/hls/stream_format_updater.ex 86.66% <50.00%> (ø)
lib/membrane_rtc_engine/endpoints/hls_endpoint.ex 77.08% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1620023...d823a31. Read the comment docs.

Copy link
Contributor

@mickel8 mickel8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that changes in fixtures are expected?


Process.sleep(15_000)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like those changes 👍

@Karolk99
Copy link
Contributor Author

I assume that changes in fixtures are expected?

Yes, besides waiting for a message instead of Process.sleep() I also fixed one problem with propagating end_of_stream in the HLS pipeline that's why fixtures look different. I also checked those files with the use of ffplay.

@Karolk99 Karolk99 merged commit 2a08dee into master Feb 27, 2023
@Karolk99 Karolk99 deleted the refactor-hls-tests branch February 27, 2023 13:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants