This repository has been archived by the owner on Sep 19, 2024. It is now read-only.
Send update_track_metadata also for pending subscriptions #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
suggested changes
Feb 10, 2023
| @@ -101,8 +102,11 @@ defmodule Membrane.RTC.EngineTest do | |||
| ) | |||
|
|
|||
| assert_receive {:track_metadata_updated, %Track{id: ^track_id, metadata: "new-metadata"}} | |||
|
|
|||
| :ok = Engine.terminate(rtc_engine) | |||
There was a problem hiding this comment.
Let's put this in on_exit as assert :ok == Engine.terminate(rtc_engine, blocking?: true)
| @@ -90,6 +90,7 @@ defmodule Membrane.RTC.EngineTest do | |||
| describe ":update_track_metadata" do | |||
| setup :setup_for_metadata_tests | |||
|
|
|||
| @tag :debug | |||
| @@ -19,8 +19,6 @@ defmodule Membrane.RTC.HLSEndpointTest do | |||
|
|
|||
| Engine.register(pid, self()) | |||
|
|
|||
| on_exit(fn -> Engine.terminate(pid, blocking?: true) end) | |||
There was a problem hiding this comment.
Suggested change
| on_exit(fn -> Engine.terminate(pid, blocking?: true) end) | |
| on_exit(fn -> assert :ok == Engine.terminate(pid, blocking?: true) end) |
Comment on lines
198
to
228
| Engine.message_endpoint( | ||
| rtc_engine, | ||
| "track-endpoint", | ||
| {:execute_actions, [notify: {:track_ready, track.id, hd(track.variants), track.encoding}]} | ||
| ) |
There was a problem hiding this comment.
Could you create a separate story in Jira for adding tests for track_ready?
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
- Coverage 57.63% 57.07% -0.56%
==========================================
Files 38 35 -3
Lines 1787 1589 -198
==========================================
- Hits 1030 907 -123
+ Misses 757 682 -75
Continue to review full report at Codecov.
|
mickel8
approved these changes
Feb 23, 2023
Rados13
force-pushed
the
RTC-134-some-tests-in-the-rtc-engine-dont-terminate-engine-correctly
branch
from
4058601
to
2d40e63
Compare
Rados13
force-pushed
the
RTC-134-some-tests-in-the-rtc-engine-dont-terminate-engine-correctly
branch
from
bdf5485
to
7647c01
Compare
Rados13
deleted the
RTC-134-some-tests-in-the-rtc-engine-dont-terminate-engine-correctly
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.