-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pure Elixir G.711 implementation #1
Conversation
test/parser_test.exs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dunno if that's what you had in mind, but I've done something to alleviate the code duplication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought more of things like this:
test_cases = [
{"adds timestamps",@stream_format, %Parser{overwrite_pts?: true}, 0}
{"adds timestamps with offset",@stream_format, %Parser{overwrite_pts?: true, pts_offset: 10}, 10},
{"can have `RemoteStream` as input",%RemoteStream{}, %Parser{stream_format: @stream_format}, 0},
]
for {test_name, source_stream_format,parser, offset} <- test_cases do
test "parser #{test_name}" do
...
end
end
But I think that for start this is good enough.
test/parser_test.exs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought more of things like this:
test_cases = [
{"adds timestamps",@stream_format, %Parser{overwrite_pts?: true}, 0}
{"adds timestamps with offset",@stream_format, %Parser{overwrite_pts?: true, pts_offset: 10}, 10},
{"can have `RemoteStream` as input",%RemoteStream{}, %Parser{stream_format: @stream_format}, 0},
]
for {test_name, source_stream_format,parser, offset} <- test_cases do
test "parser #{test_name}" do
...
end
end
But I think that for start this is good enough.
No description provided.