Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Add Room Manager example #1

Merged
merged 5 commits into from
May 15, 2024
Merged

Add Room Manager example #1

merged 5 commits into from
May 15, 2024

Conversation

balins
Copy link
Collaborator

@balins balins commented May 8, 2024

This PR simplifies (hopefully) and migrates the Room Manager POC that has been used internally by our dev team.

@balins balins self-assigned this May 8, 2024
@balins balins force-pushed the jb/room-manager-example branch 13 times, most recently from e624d5f to b0634c5 Compare May 8, 2024 14:32
@balins balins marked this pull request as ready for review May 8, 2024 14:33
@balins balins requested a review from kamil-stasiak May 8, 2024 14:33
@balins balins force-pushed the jb/room-manager-example branch from b0634c5 to 95602d0 Compare May 8, 2024 14:37
@kamil-stasiak
Copy link

Nice job! You've created very simple code. However, I don't understand why you changed Fastify to Express. We had a working solution based on Fastify.

This approach is simpler, but it lacks some features from the previous one, such as:

  • Environment variables validation
  • Logger
  • Meaningful error responses in responses
  • OpenAPI schema
  • HTTP endpoint parameter and response validation

I thought that we would develop this app as both an Elixir Videoroom replacement and a simple example. For me, code written in Fastify is just as easy to read as one written in Express.

kamil-stasiak
kamil-stasiak previously approved these changes May 15, 2024
@balins
Copy link
Collaborator Author

balins commented May 15, 2024

The reason behind replacing Fastify with Express was popularity, while I agree Fastify is better for building production-grade apps, Express is a much more known framework, which counts towards simplicity of the example, which was our number 1 objective. As for the missing features, I'm not sure if they are crucial. The purpose of this example was to demonstrate the SDK usage as simply as possible.

Whether to make this example a replacement for the Elixir room manager is TBD. But if we want to do this, I think we should drop the simplicity requirement and make this example more sophisticated (basically, rewind it to your Room Manager POC).

@balins balins force-pushed the jb/room-manager-example branch from 95602d0 to ec7d145 Compare May 15, 2024 13:25
@balins balins merged commit 363447f into main May 15, 2024
3 checks passed
@balins balins deleted the jb/room-manager-example branch May 15, 2024 13:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants