This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
[EX-107] Remove Endpoint concept #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyman503
commented
Jul 31, 2023
Comment on lines
29
to
30
| public func setOnEncodingChangedListener(listener: ((_ trackContext: MembraneRTC.TrackContext) -> Void)?) { | ||
| trackContext.setOnEncodingChangedListener(listener: listener) |
There was a problem hiding this comment.
I'm not entirely sure what to do here, since in my opinion this should take function that takes JellyfishTrackContext as a parameter such that end user won't have to worry about witch context to use, but idk how to write this since this function can do everything in the meantime.
skyman503
commented
Jul 31, 2023
Comment on lines
12
to
16
| import struct JellyfishClientSdk.Config | ||
| import protocol JellyfishClientSdk.JellyfishClientListener | ||
| import class JellyfishClientSdk.JellyfishClientSdk | ||
| import struct JellyfishClientSdk.Peer | ||
| import class JellyfishClientSdk.TrackContext |
There was a problem hiding this comment.
Afaik if you want to import one class (TrackContext here) specifically from one library every other thing has to be also included line by line...
graszka22
reviewed
Jul 31, 2023
| import UIKit | ||
|
|
||
| import class MembraneRTC.MembraneRTC |
There was a problem hiding this comment.
do we need that? public private(set) var client: MembraneRTC? seems unused
graszka22
approved these changes
Aug 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.