Add yarn commands

[mironiasty]

EX-527

Add simple commands to automatically format/lint iOS code

[karkakol]

You should also update .githooks/pre-commit.sh script

[mironiasty]

You should also update .githooks/pre-commit.sh script

What exactly do you want to update in pre-commit.sh?

[karkakol]

You should also update .githooks/pre-commit.sh script

What exactly do you want to update in pre-commit.sh?

It should use yarn commands instead of swift-formater ... etc.

[mironiasty]

In that case, I'm not sure about it. Commands in pre-commit are designed to run only on modified files (swift-format format -i "${line}"), but commands in yarn are designed to run on all files (swift-format lint -r -s ./**/**/*.swift). So I would have to create second set of commands in yarn just for git hook. TBH I think it would make more sense to only rely on GH Actions and remove hooks in that case.

[karkakol]

In that case, I'm not sure about it. Commands in pre-commit are designed to run only on modified files (swift-format format -i "${line}"), but commands in yarn are designed to run on all files (swift-format lint -r -s ./**/**/*.swift). So I would have to create second set of commands in yarn just for git hook. TBH I think it would make more sense to only rely on GH Actions and remove hooks in that case.

Imho if we require some checks on code like format or lint it should be checked also in pre-commit, otherwise i do not see a reason for it to be present. It is annoying if pre-commit passes and then github action fails. In this case we should delete pre-commit script or update to be the same as lint/format checks.

[mironiasty]

I guess that is the point of pre-commit script - to fail if code is not 'commitable'. Not all eslint rules can be autofixed. Also there are many rules on precommit hook that can be added, that will fail commit (checking version of tools used as an example)