Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Add swift package #10

Merged
merged 4 commits into from
Aug 17, 2023
Merged

Add swift package #10

merged 4 commits into from
Aug 17, 2023

Conversation

graszka22
Copy link
Contributor

@graszka22 graszka22 commented Aug 16, 2023 •
edited
Loading

You should be able to:

  • run the demo app normally by opening xcworkspace in xcode
  • be able to edit the client code and see the changes after compiling the demo app
  • be able to install the client in any ios app using swift package (in xcode file -> add package -> link to github repo)

@graszka22 graszka22 force-pushed the graszka22/swift-package branch from aa1b224 to 8faffb5 Compare August 16, 2023 20:22
@graszka22 graszka22 marked this pull request as ready for review August 16, 2023 23:11
@graszka22 graszka22 requested a review from incubo4u August 16, 2023 23:11
incubo4u
incubo4u approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@incubo4u incubo4u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌻

@graszka22 graszka22 merged commit edc0d5f into main Aug 17, 2023
@graszka22 graszka22 deleted the graszka22/swift-package branch August 17, 2023 11:38
mironiasty pushed a commit that referenced this pull request Apr 26, 2024
@graszka22 @mickel8
[MV-166] Update set encoding api (#10)
02e4595 
* [MV-166] Update set encoding api

* Update MembraneRTC/Sources/MembraneRTC/Events/Event.swift

Co-authored-by: Michał Śledź <[email protected]>

Co-authored-by: Michał Śledź <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@incubo4u incubo4u incubo4u approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graszka22 @incubo4u